Skip to content

Improve cloneNode method signature #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Improve cloneNode method signature #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1276,6 +1276,7 @@ interface Attr extends Node {
readonly prefix: string | null;
readonly specified: boolean;
value: string;
cloneNode(deep?: boolean): Attr;
}

declare var Attr: {
Expand Down Expand Up @@ -1655,6 +1656,7 @@ interface CharacterData extends Node, ChildNode {
insertData(offset: number, arg: string): void;
replaceData(offset: number, count: number, arg: string): void;
substringData(offset: number, count: number): string;
cloneNode(deep?: boolean): CharacterData;
}

declare var CharacterData: {
Expand Down Expand Up @@ -3301,6 +3303,7 @@ interface Document extends Node, GlobalEventHandlers, NodeSelector, DocumentEven
* @param content The text and HTML tags to write.
*/
writeln(...content: string[]): void;
cloneNode(deep?: boolean): Document;
addEventListener<K extends keyof DocumentEventMap>(type: K, listener: (this: Document, ev: DocumentEventMap[K]) => any, useCapture?: boolean): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, useCapture?: boolean): void;
}
Expand All @@ -3311,6 +3314,7 @@ declare var Document: {
};

interface DocumentFragment extends Node, NodeSelector, ParentNode {
cloneNode(deep?: boolean): DocumentFragment;
getElementById(elementId: string): HTMLElement | null;
}

Expand All @@ -3326,6 +3330,7 @@ interface DocumentType extends Node, ChildNode {
readonly notations: NamedNodeMap;
readonly publicId: string;
readonly systemId: string;
cloneNode(deep?: boolean): DocumentType;
}

declare var DocumentType: {
Expand Down Expand Up @@ -3612,6 +3617,7 @@ interface Element extends Node, GlobalEventHandlers, ElementTraversal, NodeSelec
webkitMatchesSelector(selectors: string): boolean;
webkitRequestFullscreen(): void;
webkitRequestFullScreen(): void;
cloneNode(deep?: boolean): this;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not use this here. this makes everything that extends HTMLElement generic.

getElementsByClassName(classNames: string): NodeListOf<Element>;
matches(selector: string): boolean;
closest(selector: string): Element | null;
Expand Down
48 changes: 48 additions & 0 deletions inputfiles/addedTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,52 @@
[
{
"kind": "method",
"interface": "Attr",
"name": "cloneNode",
"signatures": [
"cloneNode(deep?: boolean): Attr"
]
},
{
"kind": "method",
"interface": "CharacterData",
"name": "cloneNode",
"signatures": [
"cloneNode(deep?: boolean): CharacterData"
]
},
{
"kind": "method",
"interface": "Document",
"name": "cloneNode",
"signatures": [
"cloneNode(deep?: boolean): Document"
]
},
{
"kind": "method",
"interface": "DocumentFragment",
"name": "cloneNode",
"signatures": [
"cloneNode(deep?: boolean): DocumentFragment"
]
},
{
"kind": "method",
"interface": "DocumentType",
"name": "cloneNode",
"signatures": [
"cloneNode(deep?: boolean): DocumentType"
]
},
{
"kind": "method",
"interface": "Element",
"name": "cloneNode",
"signatures": [
"cloneNode(deep?: boolean): this"
]
},
{
"kind": "interface",
"name": "BroadcastChannel",
Expand Down