Fix HkdfParams use and remove HkdfCtrParams #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Coincidentally, I ran into this issue earlier today and came up with essentially the same fix before noticing this PR.
|
|
Gentle ping, @sandersn |
Closed
|
Looks good, thanks! |
benknab
added a commit
to benknab/tarnhelm
that referenced
this pull request
Dec 6, 2020
benknab
added a commit
to benknab/tarnhelm
that referenced
this pull request
Dec 6, 2020
* Bump packages Fixes security issues in object-path and node-fetch * Add _static to prettier ignore * Update code style to comply with new ESLint rules * Update crypto types See: microsoft/TypeScript-DOM-lib-generator#879 * Fix WebSocket async listen function response type
benknab
added a commit
to benknab/tarnhelm
that referenced
this pull request
Dec 6, 2020
* Bump packages to fix security issues (#17) * Bump packages Fixes security issues in object-path and node-fetch * Add _static to prettier ignore * Update code style to comply with new ESLint rules * Update crypto types See: microsoft/TypeScript-DOM-lib-generator#879 * Fix WebSocket async listen function response type * Update check scripts and configs * Apply new style, lint, type rules
benknab
added a commit
to benknab/tarnhelm
that referenced
this pull request
Jan 11, 2021
* Add ln-service * Add LND config * Add basic lightning network payment integration * Add CoinGecko to query bitcoin price * Update upload params validation * Add price quote calculation * Apply eslint override to one line only * Add file limit equal to paid size * Fix empty file meta * Add LN invoice QR code * Add price estimate row * Fix wrapped glitch effect in button * Add invoice, invoice update data restriction * Merge package update with lnd (#18) * Bump packages to fix security issues (#17) * Bump packages Fixes security issues in object-path and node-fetch * Add _static to prettier ignore * Update code style to comply with new ESLint rules * Update crypto types See: microsoft/TypeScript-DOM-lib-generator#879 * Fix WebSocket async listen function response type * Update check scripts and configs * Apply new style, lint, type rules * Add pino logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latter was removed in 2016: w3c/webcrypto#16 with the former being in the current spec: https://w3c.github.io/webcrypto/#hkdf-params