-
Notifications
You must be signed in to change notification settings - Fork 12.8k
TypedArrays: type thisArg correctly and other issues #18425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
OK. Note that the callback parameter Would the refactoring with TypedArray help from a performance standpoint? |
I do not think you need |
|
yes, but will turn all these types into generic types. this costs more in terms of memory and in execution. and since this is the standard library everyone pays for the cost even if they never subclass typed arrays. |
For example, UInt8Array.find
All the variants have the same issues. It seems like it would be a good idea to refactor them to:
The text was updated successfully, but these errors were encountered: