Skip to content

Space added before decorated method parameter #20449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjbvz opened this issue Dec 4, 2017 · 0 comments · Fixed by #20491
Closed

Space added before decorated method parameter #20449

mjbvz opened this issue Dec 4, 2017 · 0 comments · Fixed by #20491
Labels
Bug A bug in TypeScript Domain: Formatter The issue relates to the built-in formatter Fixed A PR has been merged for this issue Help Wanted You can do this VS Code Tracked There is a VS Code equivalent to this issue

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Dec 4, 2017

From microsoft/vscode#39554

TypeScript Version: 2.7.0-dev.20171203

Code

class Test {
    constructor(@foo props: any) {
    }
}

Run format

Expected behavior:
No change

Actual behavior:
Space added:

class Test {
    constructor( @foo props: any) {
    }
}
[Trace  - 11:54:15 AM] Response received: format (92). Request took 4 ms. Success: true 
Result: [
    {
        "start": {
            "line": 2,
            "offset": 17
        },
        "end": {
            "line": 2,
            "offset": 17
        },
        "newText": " "
    }
]
@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Dec 4, 2017
@mhegazy mhegazy added Domain: Formatter The issue relates to the built-in formatter Bug A bug in TypeScript Help Wanted You can do this labels Dec 4, 2017
@mhegazy mhegazy added this to the Community milestone Dec 4, 2017
HerringtonDarkholme added a commit to HerringtonDarkholme/TypeScript that referenced this issue Dec 6, 2017
HerringtonDarkholme added a commit to HerringtonDarkholme/TypeScript that referenced this issue Dec 6, 2017
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jan 5, 2018
@mhegazy mhegazy modified the milestones: Community, TypeScript 2.7 Jan 5, 2018
errendir added a commit to errendir/TypeScript that referenced this issue Jan 7, 2018
* origin/master: (61 commits)
  Add release-2.7 to covered branches
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  API: fix types to undefined union (microsoft#20909)
  Fix conflict between formatting rules (microsoft#21038)
  Switch to block-bodied lambda
  Better name for deferred mapped type:ReverseMapped
  Slightly simplify getCodeActions
  Make fixCannotFindModule return an empty array if there is no code action
  In checkAndAggregateReturnExpressionTypes, treat MethodDeclaration in an object literal same as a FunctionExpression (microsoft#20052)
  Return string completions for indexed access types
  Check for unused getter/setter in classes (microsoft#21013)
  Only replace `implements` with a comma if the heritage clauses are sensible
  Refine extends-to-implements code fix
  Fix version of @types/node to 8.5.5 (microsoft#21019)
  fix microsoft#20449, insert space between decorators (microsoft#20491)
  findConfigFile can return undefined (microsoft#20556)
  Allowed trailing commas in type parameter/argument lists (microsoft#20599)
  Added localization instructions to CONTRIBUTING.md (microsoft#20451)
  Simplify marker names
  ...
@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Domain: Formatter The issue relates to the built-in formatter Fixed A PR has been merged for this issue Help Wanted You can do this VS Code Tracked There is a VS Code equivalent to this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants