Skip to content

Config file search only happens under projectRootPath #21209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhegazy opened this issue Jan 16, 2018 · 2 comments
Closed

Config file search only happens under projectRootPath #21209

mhegazy opened this issue Jan 16, 2018 · 2 comments
Assignees
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Jan 16, 2018

  • Create folder A, with tsconfig.json and a single file a.ts
  • Open VScode using code ./A
  • try to open a file from a different project, say src/compiler/checker.ts

Expected behavior:

the tsconfig.json for src/compiler/checker.ts is found and is loaded correctly

Actual behavior:

the tsconfig.json is not loaded, resulting in errors for missing types.

@mhegazy mhegazy added the Bug A bug in TypeScript label Jan 16, 2018
@mhegazy mhegazy added this to the TypeScript 2.8 milestone Jan 16, 2018
@sheetalkamat
Copy link
Member

Isnt this by design... Project root is suppose to be the directory till which we can lookup the config file which vscode sets as the directory of opened folder..

@mhegazy
Copy link
Contributor Author

mhegazy commented Jan 18, 2018

yes and no. we should be looking in the projectRoot first. but if it fails, we should go back to the normal lookup process.

sheetalkamat added a commit that referenced this issue Feb 20, 2018
@DanielRosenwasser DanielRosenwasser modified the milestones: TypeScript 2.8.1, TypeScript 2.8.2 Mar 22, 2018
@mhegazy mhegazy modified the milestones: TypeScript 2.8.2, TypeScript 2.9 Apr 3, 2018
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label May 4, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

3 participants