Skip to content

Debug Failure. False expression: in openExternalProjects in getOrCreateScriptInfoWorker #35734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
minestarks opened this issue Dec 17, 2019 · 1 comment · Fixed by #36109
Closed

Debug Failure. False expression: in openExternalProjects in getOrCreateScriptInfoWorker #35734

minestarks opened this issue Dec 17, 2019 · 1 comment · Fixed by #36109
Assignees
@sheetalkamat
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Milestone
TypeScript 3.8.1

Comments

@minestarks
Copy link
Member

minestarks commented Dec 17, 2019 •
edited
Loading

This is a high hitter from VS telemetry and impacts a wide range of TS versions, at least 2.7-3.7

Command: openExternalProjects

Message: Error processing request. Debug Failure. False expression:

Stack:

ProjectService.getOrCreateScriptInfoWorker(tsserver.js:137708:30)
ProjectService.getOrCreateScriptInfoNotOpenedByClientForNormalizedPath(tsserver.js:137681:33)
ProjectService.updateNonInferredProjectFiles(tsserver.js:137368:43)
ProjectService.addFilesToNonInferredProject(tsserver.js:137259:22)
ProjectService.createExternalProject(tsserver.js:137210:22)
ProjectService.openExternalProject(tsserver.js:138654:40)
ProjectService.openExternalProjects(tsserver.js:138406:26)
Session.handlers.ts.createMapFromTemplate._a.(tsserver.js:139167:46)
unknown_function(tsserver.js:140854:88)
IOSession.Session.executeWithRequestId(tsserver.js:140845:28)
IOSession.Session.executeCommand(tsserver.js:140854:33)
IOSession.Session.onMessage(tsserver.js:140877:35)
Interface.(tsserver.js:142192:27)

VS bug https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1044433
@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Jan 3, 2020
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.8.1 milestone Jan 3, 2020
@minestarks
Copy link
Member Author

Here is a repro https://developercommunity.visualstudio.com/content/problem/771738/javascript-file-in-node-module-that-begins-with-is.html

sheetalkamat added a commit that referenced this issue Jan 9, 2020
@sheetalkamat
Remove the check that if base file name starts with ^ is dynamic file…
4858f4b 
… name since those files can exist

Fixes #35734
@sheetalkamat sheetalkamat added the Fix Available A PR has been opened for this issue label Jan 9, 2020
@sheetalkamat sheetalkamat mentioned this issue Jan 9, 2020
Merged
sheetalkamat added a commit that referenced this issue Jan 10, 2020
@sheetalkamat
Remove the check that if base file name starts with ^ is dynamic file…
00b21ef 
… name since those files can exist (#36109)

Fixes #35734
@sheetalkamat sheetalkamat mentioned this issue Feb 8, 2020
Closed
Kingwl pushed a commit to Kingwl/TypeScript that referenced this issue Mar 4, 2020
@sheetalkamat @Kingwl
Remove the check that if base file name starts with ^ is dynamic file…
6bdb4d1 
… name since those files can exist (microsoft#36109)

Fixes microsoft#35734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sheetalkamat sheetalkamat

Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Milestone
TypeScript 3.8.1
3 participants
@RyanCavanaugh @sheetalkamat @minestarks