Skip to content

WebAssembly's MemoryDescriptor is missing an argument #42182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
timhwang21 opened this issue Jan 2, 2021 · 0 comments · Fixed by microsoft/TypeScript-DOM-lib-generator#967
Closed

WebAssembly's MemoryDescriptor is missing an argument #42182

timhwang21 opened this issue Jan 2, 2021 · 0 comments · Fixed by microsoft/TypeScript-DOM-lib-generator#967
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Milestone
Backlog

Comments

@timhwang21
Copy link

(I'm not sure filing in this repo is the right workflow; the contribution guidelines for Typescript-DOM-lib-generator say to first open an issue in this repo, while this repo's issue template says to directly go to Typescript-DOM-lib-generator.)

lib Update Request

Configuration Check

My compilation target is ES2015 and my lib is the default.

Missing / Incorrect Definition

The WebAssembly.Memory() constructor takes a MemoryDescriptor which is missing types for the key shared: boolean.

Sample Code

https://www.typescriptlang.org/play?#code/HYUw7gBA6iBGCCBnRIC2sA2BPAdAWTQHsAnLACgG8AoCWiAS2HoBd6BDDALggA4AGADQ06qNgA96qAK6pu-IXQiIAFm2IgAJt2bEpIARAD0hiM2X1ES5YSkYNEWCAgA3DvQ1UAvgEogA

Documentation Link

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/Memory/Memory#Parameters
timhwang21 added a commit to timhwang21/TypeScript-DOM-lib-generator that referenced this issue Jan 2, 2021
@timhwang21
feat(WebAssembly): Add shared: boolean for MemoryDescriptor dict
aa02f35 
Closes microsoft/TypeScript#42182.

[MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/Memory/Memory#Parameters)

Note that this parameter is missing from the [spec](https://www.w3.org/TR/2019/REC-wasm-js-api-1-20191205/#memories).

[browser-compat-data](https://github.com/mdn/browser-compat-data/blob/5c9fce3086e91e9994ce8e8b37791c34512718e9/javascript/builtins/webassembly/Memory.json#L112)
@timhwang21 timhwang21 mentioned this issue Jan 2, 2021
Merged
@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this labels Jan 6, 2021
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Jan 6, 2021
sandersn pushed a commit to microsoft/TypeScript-DOM-lib-generator that referenced this issue Feb 23, 2021
@timhwang21
feat(WebAssembly): Add shared: boolean for MemoryDescriptor dict (#…
a3cf799 
…967)

Closes microsoft/TypeScript#42182.

[MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/Memory/Memory#Parameters)

Note that this parameter is missing from the [spec](https://www.w3.org/TR/2019/REC-wasm-js-api-1-20191205/#memories).

[browser-compat-data](https://github.com/mdn/browser-compat-data/blob/5c9fce3086e91e9994ce8e8b37791c34512718e9/javascript/builtins/webassembly/Memory.json#L112)
saschanaz pushed a commit to saschanaz/types-web that referenced this issue Feb 28, 2021
@timhwang21 @saschanaz
feat(types): Add shared: boolean for MemoryDescriptor dict
a225373 
Closes microsoft/TypeScript#42182.

[MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/Memory/Memory#Parameters)

Note that this parameter is missing from the [spec](https://www.w3.org/TR/2019/REC-wasm-js-api-1-20191205/#memories).

[browser-compat-data](https://github.com/mdn/browser-compat-data/blob/5c9fce3086e91e9994ce8e8b37791c34512718e9/javascript/builtins/webassembly/Memory.json#L112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Projects
None yet
Milestone
Backlog
2 participants
@timhwang21 @RyanCavanaugh