Skip to content

material-ui docs OOM after intersectionState propagation in relations #53009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jakebailey opened this issue Feb 27, 2023 · 0 comments · Fixed by #53012
Closed

material-ui docs OOM after intersectionState propagation in relations #53009

jakebailey opened this issue Feb 27, 2023 · 0 comments · Fixed by #53012
Assignees
@ahejlsberg
Labels
Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output Domain: Performance Reports of unusually slow behavior Fix Available A PR has been opened for this issue
Milestone
TypeScript 5.0.2

Comments

@jakebailey
Copy link
Member

While redoing benchmarks for the 5.0 RC blog post, I foud that material-ui's docs now OOM.

A bisect points to #52392, and reverting this PR makes things compile at a reasonable speed again.

Steps to reproduce what I'm doing exactly:

$ git clone https://github.com/mui/material-ui.git
$ cd material-ui
$ yarn
$ node ~/path/to/tsc.js -p ./docs

cc @ahejlsberg
@DanielRosenwasser DanielRosenwasser added Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output Domain: Performance Reports of unusually slow behavior labels Feb 28, 2023
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 5.0.2 milestone Feb 28, 2023
@ahejlsberg ahejlsberg mentioned this issue Feb 28, 2023
Merged
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahejlsberg ahejlsberg

Labels
Crash For flagging bugs which are compiler or service crashes or unclean exits, rather than bad output Domain: Performance Reports of unusually slow behavior Fix Available A PR has been opened for this issue
Projects
None yet
Milestone
TypeScript 5.0.2
Development

Successfully merging a pull request may close this issue.

Omit intersection property check when source includes target microsoft/TypeScript
4 participants
@DanielRosenwasser @ahejlsberg @jakebailey @typescript-bot