Consistently propagate `intersectionState` in relations #52392

ahejlsberg · 2023-01-24T16:03:36Z

ahejlsberg · 2023-01-24T16:04:17Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2023-01-24T16:04:20Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 2c938a4. You can monitor the build here.

typescript-bot · 2023-01-24T16:04:20Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 2c938a4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-24T16:04:20Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 2c938a4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-24T16:04:20Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 2c938a4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-24T16:04:21Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 2c938a4. You can monitor the build here.

typescript-bot · 2023-01-24T16:17:12Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/52392/merge:

Everything looks good!

typescript-bot · 2023-01-24T16:18:53Z

Heya @ahejlsberg, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot · 2023-01-24T16:26:56Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52392

_Metric	_main	₅₂₃₉₂	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{359,056k (± 0.01%)}	_{359,014k (± 0.01%)}	_{-41k (- 0.01%)}	_358,982k	_359,039k
_{Parse Time}	_{4.19s (± 0.44%)}	_{4.18s (± 0.41%)}	_{-0.01s (- 0.20%)}	_4.16s	_4.21s
_{Bind Time}	_{1.22s (± 0.33%)}	_{1.22s (± 0.45%)}	_{+0.00s (+ 0.27%)}	_1.22s	_1.23s
_{Check Time}	_{9.55s (± 0.18%)}	_{9.54s (± 0.29%)}	_{-0.01s (- 0.16%)}	_9.49s	_9.56s
_{Emit Time}	_{8.08s (± 0.48%)}	_{8.11s (± 0.20%)}	_{+0.03s (+ 0.39%)}	_8.09s	_8.13s
_{Total Time}	_{23.04s (± 0.16%)}	_{23.05s (± 0.09%)}	_{+0.01s (+ 0.04%)}	_23.01s	_23.07s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{194,251k (± 0.03%)}	_{194,266k (± 0.03%)}	_{+15k (+ 0.01%)}	_194,194k	_194,348k
_{Parse Time}	_{1.81s (± 0.45%)}	_{1.82s (± 0.45%)}	_{+0.01s (+ 0.55%)}	_1.81s	_1.83s
_{Bind Time}	_{0.84s (± 1.06%)}	_{0.84s (± 0.99%)}	_{+0.01s (+ 0.60%)}	_0.84s	_0.86s
_{Check Time}	_{10.37s (± 0.36%)}	_{10.37s (± 0.50%)}	_{+0.00s (+ 0.02%)}	_10.32s	_10.46s
_{Emit Time}	_{3.06s (± 0.77%)}	_{3.07s (± 0.76%)}	_{+0.01s (+ 0.22%)}	_3.04s	_3.10s
_{Total Time}	_{16.08s (± 0.19%)}	_{16.10s (± 0.22%)}	_{+0.02s (+ 0.12%)}	_16.07s	_16.16s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,217k (± 0.01%)}	_{343,252k (± 0.01%)}	_{+36k (+ 0.01%)}	_343,227k	_343,277k
_{Parse Time}	_{3.14s (± 0.82%)}	_{3.18s (± 1.87%)}	_{+0.05s (+ 1.49%)}	_3.12s	_3.25s
_{Bind Time}	_{1.11s (± 0.89%)}	_{1.11s (± 0.46%)}	_{+0.00s (+ 0.45%)}	_1.11s	_1.12s
_{Check Time}	_{7.89s (± 0.25%)}	_{7.92s (± 0.39%)}	_{+0.03s (+ 0.38%)}	_7.88s	_7.96s
_{Emit Time}	_{4.57s (± 0.39%)}	_{4.54s (± 0.36%)}	_{-0.03s (- 0.62%)}	_4.51s	_4.55s
_{Total Time}	_{16.70s (± 0.24%)}	_{16.75s (± 0.27%)}	_{+0.05s (+ 0.33%)}	_16.70s	_16.81s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,713k (± 0.01%)}	_{299,706k (± 0.00%)}	_{-7k (- 0.00%)}	_299,685k	_299,725k
_{Parse Time}	_{2.47s (± 1.40%)}	_{2.49s (± 2.22%)}	_{+0.02s (+ 0.88%)}	_2.43s	_2.56s
_{Bind Time}	_{1.25s (± 0.33%)}	_{1.26s (± 0.65%)}	_{+0.00s (+ 0.40%)}	_1.25s	_1.27s
_{Check Time}	_{7.53s (± 0.50%)}	_{7.52s (± 0.36%)}	_{-0.01s (- 0.09%)}	_7.48s	_7.56s
_{Emit Time}	_{4.24s (± 0.79%)}	_{4.23s (± 0.50%)}	_{-0.01s (- 0.24%)}	_4.20s	_4.26s
_{Total Time}	_{15.49s (± 0.38%)}	_{15.50s (± 0.42%)}	_{+0.01s (+ 0.05%)}	_15.42s	_15.56s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,133k (± 0.02%)}	_{476,116k (± 0.01%)}	_{-17k (- 0.00%)}	_476,088k	_476,190k
_{Parse Time}	_{3.72s (± 0.40%)}	_{3.72s (± 0.38%)}	_{+0.00s (+ 0.09%)}	_3.70s	_3.74s
_{Bind Time}	_{1.02s (± 0.00%)}	_{1.02s (± 0.00%)}	_{0.00s ( 0.00%)}	_1.02s	_1.02s
_{Check Time}	_{18.05s (± 0.13%)}	_{18.07s (± 0.22%)}	_{+0.03s (+ 0.17%)}	_18.02s	_18.13s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.78s (± 0.14%)}	_{22.82s (± 0.14%)}	_{+0.04s (+ 0.17%)}	_22.77s	_22.84s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{546,280k (± 0.03%)}	_{558,623k (± 0.02%)}	_{+12,344k (+ 2.26%)}	_558,545k	_558,798k
_{Parse Time}	_{4.76s (± 0.57%)}	_{4.78s (± 0.36%)}	_{+0.02s (+ 0.42%)}	_4.76s	_4.80s
_{Bind Time}	_{1.81s (± 4.15%)}	_{1.84s (± 0.66%)}	_{+0.03s (+ 1.75%)}	_1.83s	_1.86s
_{Check Time}	_{2.98s (± 2.58%)}	_{3.32s (± 0.36%)}	_{+0.35s (+11.58%)}	_3.31s	_3.34s
_{Emit Time}	_{0.09s (± 4.45%)}	_{0.09s (± 0.00%)}	_{-0.00s (- 1.82%)}	_0.09s	_0.09s
_{Total Time}	_{9.65s (± 0.47%)}	_{10.04s (± 0.24%)}	_{+0.39s (+ 4.01%)}	_10.01s	_10.08s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₉₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-01-24T17:50:31Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/52392/merge:

Everything looks good!

RyanCavanaugh · 2023-01-24T21:25:00Z

I suspect this might fix #52397?

ahejlsberg · 2023-01-24T21:41:32Z

I suspect this might fix #52397?

It does indeed.

ahejlsberg · 2023-01-25T20:54:32Z

@typescript-bot test this
@typescript-bot user test this inline
@typescript-bot run dt
@typescript-bot perf test faster
@typescript-bot test top100

typescript-bot · 2023-01-25T20:54:35Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at 02269e4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-25T20:54:35Z

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 02269e4. You can monitor the build here.

typescript-bot · 2023-01-25T20:54:35Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at 02269e4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-25T20:54:35Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at 02269e4. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-25T20:54:35Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 02269e4. You can monitor the build here.

typescript-bot · 2023-01-25T21:07:39Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/52392/merge:

Everything looks good!

typescript-bot · 2023-01-25T21:13:11Z

Heya @ahejlsberg, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot · 2023-01-25T22:00:13Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52392

_Metric	_main	₅₂₃₉₂	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{359,206k (± 0.01%)}	_{359,184k (± 0.01%)}	_{-23k (- 0.01%)}	_359,154k	_359,235k
_{Parse Time}	_{4.17s (± 0.55%)}	_{4.19s (± 0.32%)}	_{+0.02s (+ 0.44%)}	_4.17s	_4.21s
_{Bind Time}	_{1.22s (± 0.52%)}	_{1.23s (± 0.42%)}	_{+0.01s (+ 0.55%)}	_1.22s	_1.23s
_{Check Time}	_{9.40s (± 0.35%)}	_{9.44s (± 0.51%)}	_{+0.04s (+ 0.39%)}	_9.38s	_9.50s
_{Emit Time}	_{8.06s (± 0.65%)}	_{8.09s (± 0.60%)}	_{+0.03s (+ 0.37%)}	_8.03s	_8.17s
_{Total Time}	_{22.85s (± 0.25%)}	_{22.94s (± 0.43%)}	_{+0.09s (+ 0.38%)}	_22.81s	_23.10s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{194,205k (± 0.04%)}	_{193,874k (± 0.01%)}	_{-330k (- 0.17%)}	_193,835k	_193,910k
_{Parse Time}	_{1.80s (± 0.29%)}	_{1.81s (± 0.54%)}	_{+0.01s (+ 0.28%)}	_1.80s	_1.82s
_{Bind Time}	_{0.85s (± 0.00%)}	_{0.84s (± 1.24%)}	_{-0.01s (- 0.59%)}	_0.83s	_0.86s
_{Check Time}	_{10.36s (± 0.57%)}	_{10.39s (± 0.60%)}	_{+0.03s (+ 0.32%)}	_10.34s	_10.51s
_{Emit Time}	_{3.06s (± 1.52%)}	_{3.07s (± 0.48%)}	_{+0.01s (+ 0.27%)}	_3.05s	_3.09s
_{Total Time}	_{16.07s (± 0.52%)}	_{16.12s (± 0.38%)}	_{+0.05s (+ 0.29%)}	_16.05s	_16.23s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,261k (± 0.01%)}	_{343,271k (± 0.01%)}	_{+10k (+ 0.00%)}	_343,230k	_343,312k
_{Parse Time}	_{3.15s (± 1.40%)}	_{3.17s (± 0.88%)}	_{+0.02s (+ 0.74%)}	_3.14s	_3.22s
_{Bind Time}	_{1.11s (± 0.37%)}	_{1.11s (± 0.75%)}	_{+0.01s (+ 0.60%)}	_1.11s	_1.13s
_{Check Time}	_{7.71s (± 0.07%)}	_{7.75s (± 0.31%)}	_{+0.04s (+ 0.52%)}	_7.73s	_7.80s
_{Emit Time}	_{4.50s (± 0.77%)}	_{4.54s (± 0.43%)}	_{+0.04s (+ 0.89%)}	_4.52s	_4.57s
_{Total Time}	_{16.48s (± 0.22%)}	_{16.58s (± 0.26%)}	_{+0.11s (+ 0.65%)}	_16.55s	_16.65s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,768k (± 0.01%)}	_{299,743k (± 0.00%)}	_{-25k (- 0.01%)}	_299,727k	_299,760k
_{Parse Time}	_{2.49s (± 1.47%)}	_{2.47s (± 0.98%)}	_{-0.01s (- 0.60%)}	_2.43s	_2.49s
_{Bind Time}	_{1.26s (± 0.41%)}	_{1.26s (± 0.60%)}	_{+0.00s (+ 0.13%)}	_1.25s	_1.27s
_{Check Time}	_{7.18s (± 0.20%)}	_{7.21s (± 0.42%)}	_{+0.03s (+ 0.39%)}	_7.17s	_7.25s
_{Emit Time}	_{4.23s (± 0.83%)}	_{4.22s (± 0.53%)}	_{-0.00s (- 0.04%)}	_4.20s	_4.26s
_{Total Time}	_{15.15s (± 0.30%)}	_{15.16s (± 0.27%)}	_{+0.01s (+ 0.08%)}	_15.09s	_15.21s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,092k (± 0.02%)}	_{476,090k (± 0.01%)}	_{-3k (- 0.00%)}	_475,998k	_476,164k
_{Parse Time}	_{3.70s (± 0.33%)}	_{3.72s (± 0.31%)}	_{+0.02s (+ 0.41%)}	_3.70s	_3.73s
_{Bind Time}	_{1.02s (± 0.74%)}	_{1.03s (± 0.79%)}	_{+0.01s (+ 0.82%)}	_1.02s	_1.04s
_{Check Time}	_{18.06s (± 0.23%)}	_{18.18s (± 0.41%)}	_{+0.12s (+ 0.65%)}	_18.10s	_18.27s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.78s (± 0.18%)}	_{22.92s (± 0.32%)}	_{+0.14s (+ 0.61%)}	_22.85s	_23.01s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{546,227k (± 0.01%)}	_{546,843k (± 0.04%)}	_{+616k (+ 0.11%)}	_546,633k	_547,138k
_{Parse Time}	_{4.75s (± 0.25%)}	_{4.77s (± 0.37%)}	_{+0.03s (+ 0.56%)}	_4.75s	_4.80s
_{Bind Time}	_{1.81s (± 3.84%)}	_{1.76s (± 5.75%)}	_{-0.05s (- 2.94%)}	_1.66s	_1.87s
_{Check Time}	_{3.00s (± 2.69%)}	_{3.11s (± 3.48%)}	_{+0.11s (+ 3.73%)}	_3.00s	_3.21s
_{Emit Time}	_{0.09s (± 5.53%)}	_{0.09s (± 0.00%)}	_{🟩-0.00s (- 3.57%)}	_0.09s	_0.09s
_{Total Time}	_{9.65s (± 0.19%)}	_{9.73s (± 0.26%)}	_{+0.09s (+ 0.92%)}	_9.71s	_9.77s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₉₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

ahejlsberg · 2023-01-25T22:08:21Z

@typescript-bot perf test faster

typescript-bot · 2023-01-28T16:22:21Z

Heya @ahejlsberg, I've started to run the diff-based user code test suite on this PR at c930975. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-28T16:22:21Z

Heya @ahejlsberg, I've started to run the diff-based top-repos suite on this PR at c930975. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-28T16:22:21Z

Heya @ahejlsberg, I've started to run the extended test suite on this PR at c930975. You can monitor the build here.

typescript-bot · 2023-01-28T16:22:21Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at c930975. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-28T16:35:54Z

@ahejlsberg Here are the results of running the user test suite comparing main and refs/pull/52392/merge:

Everything looks good!

typescript-bot · 2023-01-28T16:41:34Z

Heya @ahejlsberg, I've run the RWC suite on this PR - assuming you're on the TS core team, you can view the resulting diff here.

typescript-bot · 2023-01-28T16:46:10Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52392

_Metric	_main	₅₂₃₉₂	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{359,204k (± 0.01%)}	_{359,171k (± 0.00%)}	_{-34k (- 0.01%)}	_359,154k	_359,189k
_{Parse Time}	_{4.19s (± 0.36%)}	_{4.19s (± 0.25%)}	_{0.00s ( 0.00%)}	_4.18s	_4.21s
_{Bind Time}	_{1.22s (± 0.67%)}	_{1.23s (± 0.42%)}	_{+0.00s (+ 0.27%)}	_1.22s	_1.23s
_{Check Time}	_{9.41s (± 0.59%)}	_{9.44s (± 0.36%)}	_{+0.03s (+ 0.30%)}	_9.40s	_9.49s
_{Emit Time}	_{8.05s (± 0.43%)}	_{8.07s (± 0.55%)}	_{+0.03s (+ 0.31%)}	_8.00s	_8.12s
_{Total Time}	_{22.87s (± 0.21%)}	_{22.93s (± 0.29%)}	_{+0.06s (+ 0.26%)}	_22.87s	_23.04s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{194,243k (± 0.04%)}	_{194,502k (± 0.72%)}	_{+259k (+ 0.13%)}	_193,857k	_197,371k
_{Parse Time}	_{1.80s (± 0.45%)}	_{1.81s (± 0.57%)}	_{+0.01s (+ 0.55%)}	_1.80s	_1.83s
_{Bind Time}	_{0.84s (± 0.61%)}	_{0.85s (± 1.16%)}	_{+0.01s (+ 0.59%)}	_0.84s	_0.86s
_{Check Time}	_{10.39s (± 0.83%)}	_{10.49s (± 0.67%)}	_{+0.10s (+ 0.96%)}	_10.38s	_10.57s
_{Emit Time}	_{3.09s (± 1.58%)}	_{3.06s (± 0.95%)}	_{-0.03s (- 0.97%)}	_3.02s	_3.10s
_{Total Time}	_{16.12s (± 0.79%)}	_{16.21s (± 0.56%)}	_{+0.09s (+ 0.53%)}	_16.09s	_16.35s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,255k (± 0.01%)}	_{343,268k (± 0.01%)}	_{+13k (+ 0.00%)}	_343,250k	_343,316k
_{Parse Time}	_{3.14s (± 0.96%)}	_{3.20s (± 1.09%)}	_{+0.06s (+ 1.96%)}	_3.16s	_3.25s
_{Bind Time}	_{1.11s (± 0.94%)}	_{1.11s (± 0.46%)}	_{-0.00s (- 0.15%)}	_1.11s	_1.12s
_{Check Time}	_{7.73s (± 0.21%)}	_{7.73s (± 0.34%)}	_{+0.01s (+ 0.11%)}	_7.69s	_7.77s
_{Emit Time}	_{4.53s (± 0.46%)}	_{4.51s (± 0.68%)}	_{-0.01s (- 0.26%)}	_4.48s	_4.56s
_{Total Time}	_{16.51s (± 0.30%)}	_{16.57s (± 0.45%)}	_{+0.06s (+ 0.38%)}	_16.48s	_16.65s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,757k (± 0.01%)}	_{299,750k (± 0.01%)}	_{-8k (- 0.00%)}	_299,736k	_299,772k
_{Parse Time}	_{2.47s (± 1.11%)}	_{2.47s (± 1.11%)}	_{+0.00s (+ 0.14%)}	_2.45s	_2.51s
_{Bind Time}	_{1.25s (± 0.82%)}	_{1.25s (± 0.67%)}	_{+0.00s (+ 0.13%)}	_1.24s	_1.26s
_{Check Time}	_{7.20s (± 0.50%)}	_{7.18s (± 0.23%)}	_{-0.02s (- 0.25%)}	_7.16s	_7.21s
_{Emit Time}	_{4.23s (± 0.96%)}	_{4.22s (± 0.46%)}	_{-0.01s (- 0.28%)}	_4.20s	_4.25s
_{Total Time}	_{15.15s (± 0.35%)}	_{15.13s (± 0.39%)}	_{-0.03s (- 0.18%)}	_15.07s	_15.24s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,077k (± 0.02%)}	_{476,092k (± 0.01%)}	_{+15k (+ 0.00%)}	_476,052k	_476,125k
_{Parse Time}	_{3.73s (± 0.44%)}	_{3.73s (± 0.28%)}	_{-0.00s (- 0.04%)}	_3.71s	_3.74s
_{Bind Time}	_{1.02s (± 0.53%)}	_{1.02s (± 0.80%)}	_{-0.00s (- 0.16%)}	_1.01s	_1.03s
_{Check Time}	_{18.13s (± 0.33%)}	_{18.17s (± 0.11%)}	_{+0.04s (+ 0.19%)}	_18.14s	_18.20s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.89s (± 0.30%)}	_{22.92s (± 0.12%)}	_{+0.03s (+ 0.12%)}	_22.88s	_22.95s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{546,316k (± 0.03%)}	_{546,726k (± 0.01%)}	_{+411k (+ 0.08%)}	_546,575k	_546,787k
_{Parse Time}	_{4.76s (± 0.47%)}	_{4.78s (± 0.45%)}	_{+0.02s (+ 0.42%)}	_4.76s	_4.81s
_{Bind Time}	_{1.85s (± 0.56%)}	_{1.75s (± 5.56%)}	_{🟩-0.09s (- 5.14%)}	_1.66s	_1.86s
_{Check Time}	_{2.96s (± 0.35%)}	_{3.16s (± 3.54%)}	_{+0.19s (+ 6.58%)}	_3.05s	_3.29s
_{Emit Time}	_{0.09s (± 5.53%)}	_{0.09s (± 0.00%)}	_{🟩-0.00s (- 3.57%)}	_0.09s	_0.09s
_{Total Time}	_{9.66s (± 0.23%)}	_{9.78s (± 0.57%)}	_{+0.11s (+ 1.16%)}	_9.70s	_9.85s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₉₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

ahejlsberg · 2023-01-28T17:13:26Z

@typescript-bot perf test faster

typescript-bot · 2023-01-28T17:13:46Z

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at c930975. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-01-28T17:39:46Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..52392

_Metric	_main	₅₂₃₉₂	_Delta	_Best	_Worst
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{359,204k (± 0.01%)}	_{359,204k (± 0.01%)}	_{-1k (- 0.00%)}	_359,186k	_359,251k
_{Parse Time}	_{4.19s (± 0.36%)}	_{4.18s (± 0.65%)}	_{-0.01s (- 0.20%)}	_4.17s	_4.24s
_{Bind Time}	_{1.22s (± 0.67%)}	_{1.22s (± 0.42%)}	_{-0.00s (- 0.00%)}	_1.22s	_1.23s
_{Check Time}	_{9.41s (± 0.59%)}	_{9.45s (± 0.44%)}	_{+0.04s (+ 0.46%)}	_9.40s	_9.50s
_{Emit Time}	_{8.05s (± 0.43%)}	_{8.07s (± 0.56%)}	_{+0.02s (+ 0.31%)}	_8.04s	_8.14s
_{Total Time}	_{22.87s (± 0.21%)}	_{22.94s (± 0.27%)}	_{+0.06s (+ 0.27%)}	_22.85s	_23.00s
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{194,243k (± 0.04%)}	_{194,559k (± 0.68%)}	_{+316k (+ 0.16%)}	_193,961k	_197,245k
_{Parse Time}	_{1.80s (± 0.45%)}	_{1.80s (± 0.29%)}	_{0.00s ( 0.00%)}	_1.80s	_1.81s
_{Bind Time}	_{0.84s (± 0.61%)}	_{0.84s (± 0.97%)}	_{0.00s ( 0.00%)}	_0.83s	_0.85s
_{Check Time}	_{10.39s (± 0.83%)}	_{10.45s (± 0.66%)}	_{+0.06s (+ 0.58%)}	_10.38s	_10.55s
_{Emit Time}	_{3.09s (± 1.58%)}	_{3.06s (± 0.93%)}	_{-0.03s (- 1.02%)}	_3.03s	_3.11s
_{Total Time}	_{16.12s (± 0.79%)}	_{16.15s (± 0.52%)}	_{+0.03s (+ 0.18%)}	_16.04s	_16.25s
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,255k (± 0.01%)}	_{343,270k (± 0.01%)}	_{+15k (+ 0.00%)}	_343,248k	_343,307k
_{Parse Time}	_{3.14s (± 0.96%)}	_{3.17s (± 1.15%)}	_{+0.03s (+ 0.90%)}	_3.14s	_3.24s
_{Bind Time}	_{1.11s (± 0.94%)}	_{1.11s (± 0.57%)}	_{-0.00s (- 0.45%)}	_1.10s	_1.12s
_{Check Time}	_{7.73s (± 0.21%)}	_{7.75s (± 0.46%)}	_{+0.02s (+ 0.32%)}	_7.72s	_7.81s
_{Emit Time}	_{4.53s (± 0.46%)}	_{4.53s (± 0.65%)}	_{-0.00s (- 0.04%)}	_4.49s	_4.56s
_{Total Time}	_{16.51s (± 0.30%)}	_{16.56s (± 0.47%)}	_{+0.05s (+ 0.31%)}	_16.47s	_16.67s
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,757k (± 0.01%)}	_{299,755k (± 0.01%)}	_{-3k (- 0.00%)}	_299,713k	_299,786k
_{Parse Time}	_{2.47s (± 1.11%)}	_{2.47s (± 1.34%)}	_{+0.01s (+ 0.27%)}	_2.44s	_2.53s
_{Bind Time}	_{1.25s (± 0.82%)}	_{1.25s (± 1.01%)}	_{-0.00s (- 0.27%)}	_1.24s	_1.27s
_{Check Time}	_{7.20s (± 0.50%)}	_{7.20s (± 0.35%)}	_{-0.00s (- 0.02%)}	_7.17s	_7.23s
_{Emit Time}	_{4.23s (± 0.96%)}	_{4.21s (± 0.44%)}	_{-0.03s (- 0.59%)}	_4.18s	_4.22s
_{Total Time}	_{15.15s (± 0.35%)}	_{15.13s (± 0.34%)}	_{-0.02s (- 0.14%)}	_15.07s	_15.19s
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{476,077k (± 0.02%)}	_{476,107k (± 0.00%)}	_{+30k (+ 0.01%)}	_476,081k	_476,140k
_{Parse Time}	_{3.73s (± 0.44%)}	_{3.72s (± 0.22%)}	_{-0.01s (- 0.31%)}	_3.70s	_3.72s
_{Bind Time}	_{1.02s (± 0.53%)}	_{1.02s (± 0.00%)}	_{-0.01s (- 0.49%)}	_1.02s	_1.02s
_{Check Time}	_{18.13s (± 0.33%)}	_{18.17s (± 0.38%)}	_{+0.04s (+ 0.23%)}	_18.09s	_18.28s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{22.89s (± 0.30%)}	_{22.91s (± 0.32%)}	_{+0.02s (+ 0.11%)}	_22.83s	_23.03s
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{546,316k (± 0.03%)}	_{546,792k (± 0.02%)}	_{+476k (+ 0.09%)}	_546,677k	_546,912k
_{Parse Time}	_{4.76s (± 0.47%)}	_{4.76s (± 0.59%)}	_{-0.01s (- 0.10%)}	_4.72s	_4.79s
_{Bind Time}	_{1.85s (± 0.56%)}	_{1.83s (± 0.44%)}	_{-0.01s (- 0.72%)}	_1.82s	_1.84s
_{Check Time}	_{2.96s (± 0.35%)}	_{3.04s (± 1.17%)}	_{+0.07s (+ 2.47%)}	_3.00s	_3.09s
_{Emit Time}	_{0.09s (± 5.53%)}	_{0.09s (± 0.00%)}	_{🟩-0.00s (- 3.57%)}	_0.09s	_0.09s
_{Total Time}	_{9.66s (± 0.23%)}	_{9.72s (± 0.51%)}	_{+0.06s (+ 0.59%)}	_9.65s	_9.79s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

Angular - node (v16.17.1, x64)
Compiler-Unions - node (v16.17.1, x64)
Monaco - node (v16.17.1, x64)
TFS - node (v16.17.1, x64)
material-ui - node (v16.17.1, x64)
xstate - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₃₉₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-01-28T17:50:23Z

@ahejlsberg Here are the results of running the top-repos suite comparing main and refs/pull/52392/merge:

Everything looks good!

ahejlsberg · 2023-01-28T20:42:04Z

Everything looks good with the latest commit to handle intersections in isDeeplyNestedType.

weswigham · 2023-01-31T19:00:06Z

src/compiler/checker.ts

@@ -21811,7 +21813,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
            // No array like or unmatched property error - just issue top level error (errorInfo = undefined)
        }

-        function propertiesRelatedTo(source: Type, target: Type, reportErrors: boolean, excludedProperties: Set<__String> | undefined, intersectionState: IntersectionState): Ternary {
+        function propertiesRelatedTo(source: Type, target: Type, reportErrors: boolean, excludedProperties: Set<__String> | undefined, optionalsOnly: boolean, intersectionState: IntersectionState): Ternary {


Rather than add a new boolean parameter to this function that we have to pass everywhere, could we not use the existing excludedProperties parameter to exclude all the non-optional properties at the single callsite we wanted to?

Yeah, I considered that, but didn't want the overhead of constructing a new set, and the function is only called in three places.

ahejlsberg added 3 commits January 24, 2023 07:56

Consistently propagate intersectionState in relations

f47e7b2

Accept new baselines

deaa37c

Add regression test

2c938a4

typescript-bot assigned ahejlsberg Jan 24, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 24, 2023

ahejlsberg added 2 commits January 25, 2023 12:49

Do less work in addtional check of intersections

09c7d02

Remove unnecessary check

02269e4

Update comment

001fbd1

ahejlsberg requested review from DanielRosenwasser, RyanCavanaugh and weswigham January 31, 2023 16:19

weswigham approved these changes Jan 31, 2023

View reviewed changes

jakebailey approved these changes Feb 1, 2023

View reviewed changes

ahejlsberg merged commit 3099385 into main Feb 2, 2023

ahejlsberg deleted the fix52252 branch February 2, 2023 15:19

RyanCavanaugh mentioned this pull request Feb 2, 2023

Design Meeting Notes, 2/1/2023 #52579

Closed

jakebailey mentioned this pull request Feb 27, 2023

material-ui docs OOM after intersectionState propagation in relations #53009

Closed

Andarist mentioned this pull request Mar 12, 2023

TS 5.1.0 dev type inference regression when combining conditional/intersection/recursive type #53211

Closed

RyanCavanaugh mentioned this pull request Mar 21, 2023

[5.0] Intersected array of intersection types with union field not compatible #53412

Closed

jakebailey mentioned this pull request Jul 10, 2023

Takes a while with high memory to calculate highly recursive types with intersections #20558

Open

Andarist mentioned this pull request Aug 14, 2023

OOME/Excessively deep type on upgrade from 4.9.4 to 5.x, introduced in 5.0.0-dev.20230203 #54517

Open

jakebailey mentioned this pull request Aug 29, 2023

Regression with TS 5. Type instantiation is excessively deep and possibly infinite.ts(2589) #53514

Open

andrewbranch mentioned this pull request Sep 11, 2023

Inconsistent type inference when changing the order of type declarations (5.0 regression) #55666

Closed

SimpleCreations mentioned this pull request Oct 24, 2023

Propagate intersectionState in typeRelatedToSomeType #56207

Merged

LukeAbby mentioned this pull request Jan 7, 2025

RangeError: Maximum call stack size exceeded Regression in #52392 #60927

Open

Consistently propagate intersectionState in relations #52392

Consistently propagate intersectionState in relations #52392

Conversation

ahejlsberg commented Jan 24, 2023 • edited Loading

ahejlsberg commented Jan 24, 2023

typescript-bot commented Jan 24, 2023 • edited Loading

typescript-bot commented Jan 24, 2023 • edited Loading

typescript-bot commented Jan 24, 2023 • edited Loading

typescript-bot commented Jan 24, 2023 • edited Loading

typescript-bot commented Jan 24, 2023 • edited Loading

typescript-bot commented Jan 24, 2023

typescript-bot commented Jan 24, 2023

typescript-bot commented Jan 24, 2023

typescript-bot commented Jan 24, 2023

RyanCavanaugh commented Jan 24, 2023

ahejlsberg commented Jan 24, 2023

ahejlsberg commented Jan 25, 2023

typescript-bot commented Jan 25, 2023 • edited Loading

typescript-bot commented Jan 25, 2023 • edited Loading

typescript-bot commented Jan 25, 2023 • edited Loading

typescript-bot commented Jan 25, 2023 • edited Loading

typescript-bot commented Jan 25, 2023 • edited Loading

typescript-bot commented Jan 25, 2023

typescript-bot commented Jan 25, 2023

typescript-bot commented Jan 25, 2023

ahejlsberg commented Jan 25, 2023

typescript-bot commented Jan 28, 2023 • edited Loading

typescript-bot commented Jan 28, 2023 • edited Loading

typescript-bot commented Jan 28, 2023 • edited Loading

typescript-bot commented Jan 28, 2023 • edited Loading

typescript-bot commented Jan 28, 2023

typescript-bot commented Jan 28, 2023

typescript-bot commented Jan 28, 2023

ahejlsberg commented Jan 28, 2023

typescript-bot commented Jan 28, 2023 • edited Loading

typescript-bot commented Jan 28, 2023

typescript-bot commented Jan 28, 2023

ahejlsberg commented Jan 28, 2023

weswigham Jan 31, 2023

Choose a reason for hiding this comment

ahejlsberg Feb 1, 2023

Choose a reason for hiding this comment

Consistently propagate `intersectionState` in relations #52392

Consistently propagate `intersectionState` in relations #52392

ahejlsberg commented Jan 24, 2023 •

edited

Loading

typescript-bot commented Jan 24, 2023 •

edited

Loading

typescript-bot commented Jan 24, 2023 •

edited

Loading

typescript-bot commented Jan 24, 2023 •

edited

Loading

typescript-bot commented Jan 24, 2023 •

edited

Loading

typescript-bot commented Jan 24, 2023 •

edited

Loading

typescript-bot commented Jan 25, 2023 •

edited

Loading

typescript-bot commented Jan 25, 2023 •

edited

Loading

typescript-bot commented Jan 25, 2023 •

edited

Loading

typescript-bot commented Jan 25, 2023 •

edited

Loading

typescript-bot commented Jan 25, 2023 •

edited

Loading

typescript-bot commented Jan 28, 2023 •

edited

Loading

typescript-bot commented Jan 28, 2023 •

edited

Loading

typescript-bot commented Jan 28, 2023 •

edited

Loading

typescript-bot commented Jan 28, 2023 •

edited

Loading

typescript-bot commented Jan 28, 2023 •

edited

Loading