Fix deferred export of array binding pattern #10798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export function isArrayBindingElement(node: Node): node is ArrayBindingElement { | ||
| const kind = node.kind; | ||
| return kind === SyntaxKind.BindingElement | ||
| || kind === SyntaxKind.OmittedExpression; |
There was a problem hiding this comment.
It's kind of weird that a binding element uses an omitted expression
|
Looks good to me 👍 |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We parse the missing element as an
OmittedExpressionbut cast it to aBindingElementeven though it does not have the same shape. The result was an issue where the module transformer did not account for this case and code like the following would result in an exception:This PR makes the expected types more explicit and fixes the incorrect case.
Fixes #10778