Skip to content

added unittest for watching @types #11027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 22, 2016
Merged

added unittest for watching @types #11027

merged 2 commits into from
Sep 22, 2016

Conversation

vladima
Copy link
Contributor

@vladima vladima commented Sep 21, 2016

changes in this PR

  • added unit test for watching @types
  • runtests-browser: use chrome as default browser in linux
  • move checking project types version before the 'is program up-to-date' check. Reason: when new types are installed - it does not affect the list of root files so 'program-up-do-date' will yield true and we will not rebuild the program. Currently everything kind of work but for a different reason (set of root files usually does not include lib.d.ts and program pretty much always contains this file so up-do-date check fails because set of files did not match - ideally we should also fix it).

@mhegazy
Copy link
Contributor

mhegazy commented Sep 22, 2016 •
edited
Loading

👍

@vladima vladima merged commit 1fd0a8c into release-2.0.5 Sep 22, 2016
@vladima vladima mentioned this pull request Sep 22, 2016
Closed
@vladima vladima deleted the watching-types-test branch September 22, 2016 21:19
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhegazy mhegazy mhegazy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladima @mhegazy @msftclas