-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Quick fix for no-implicit-any errors to add explicit type annotation #14786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 34 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
a4ce5e6
Infer from usage quick fix
mhegazy d79fbc0
Change full function singature
mhegazy 69a4b8c
Add property/element access support
mhegazy 33467cf
Fix a few issues
mhegazy ab39813
Merge branch 'master' into inferFromUsage
mhegazy d87eae9
Some cleanup
mhegazy a18a950
Expose getArrayType and getPromiseType
mhegazy bea4591
Switch to collecting all usage before infering
mhegazy 55ffe2d
Infer array and promise type arguments
mhegazy b82dc8d
Handel enums in binary operators
mhegazy 7a52545
consolidate usage of addCandidateTypes
mhegazy 8088415
Handel rest paramters
mhegazy 0413165
Properly handel `+=` and `+` inference for numbers and strings
mhegazy ea483a7
Add print quickfixes debug helper
mhegazy ea344b2
Add rest param tests
mhegazy a1efc1a
Add optional paramter tests
mhegazy ff15dc6
Handel set accessors
mhegazy e2e43d1
Support getters
mhegazy 2929af4
Support no implicit any error for variable at use site
mhegazy b395057
Support properties
mhegazy 15eb7de
Only offer quick fix if an infered type other than any is available
mhegazy 2a9032b
Rename functions
mhegazy 057016b
Move to a separate namespace
mhegazy 32aa07d
Check cancellation token
mhegazy 5da31bb
Cleanup
mhegazy dc431e4
Check for accesibile symbols where serializing types
mhegazy 561cfe6
Remove JS support
mhegazy 002e8ad
Reorganize functions
mhegazy 3822d8d
Mark APIs as internal
mhegazy 41ed553
Fix lint errors
mhegazy c3071a8
Merge remote-tracking branch 'origin/master' into inferFromUsage
mhegazy a12dc45
Merge branch 'master' into inferFromUsage
mhegazy 791bb4a
Merge branch 'master' into inferFromUsage
DanielRosenwasser 0047ae3
Removed conflict markers.
DanielRosenwasser 5a15e93
Update 'createSymbol' to use '__String'.
DanielRosenwasser 9daaffa
Fixed most problems relating to '__String' and 'includeJsDocComments'…
DanielRosenwasser b5e94a7
Addressed most API changes.
DanielRosenwasser 3b49776
Merge remote-tracking branch 'origin/master' into inferFromUsage
DanielRosenwasser 3f488ce
Merge branch 'master' into inferFromUsage
mhegazy 6bdaf8a
Make all helpers internal
mhegazy 25f8aa6
Use a diffrent writer and not the built-in single line write
mhegazy 761bd7b
Infer types for all parameters in a parameter list instead of one at …
mhegazy ffa8272
Accept baselines
mhegazy 5abd72d
Code review commments
mhegazy 1e39d48
Respond to code review comments
mhegazy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a concern, we have multiple
never
types internally. I feel somewhat uneasy about exposing it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made them all them internal for now.