[Master] Emit parenthesis around propert/element access expression of casted object literal expression #15006
Conversation
…bject literal expression
src/compiler/transformers/ts.ts
Outdated
| // However, auto-parenthesization will not preserve parenthesis for the following case: ({ "1": "one", "2": "two" } as { [key: string]: string })[x]. | ||
| // so we have to manually preserve it here. | ||
| const shouldPreserveParen = (isPropertyAccessExpression(node.parent) || isElementAccessExpression(node.parent)) && | ||
| isObjectLiteralExpression((expression as PartiallyEmittedExpression).expression); |
There was a problem hiding this comment.
This is not the correct place to make a change. If we were to take this change, another feature at a later date could run into the same issue. Instead, we should make this change in the parenthesization logic in factory.ts.
If you look at parenthesizeExpressionForExpressionStatement, we check the kind of the left-most expression. However, in parenthesizeConciseBody we are not performing the same check.
I would recommend we modify parenthesizeConciseBody to call getLeftmostExpression instead of skipParenthesizedExpressions. That should correct this issue in a single place.
src/compiler/factory.ts
Outdated
| @@ -3492,7 +3492,8 @@ namespace ts { | |||
|
|
|||
| export function parenthesizeConciseBody(body: ConciseBody): ConciseBody { | |||
| const emittedBody = skipPartiallyEmittedExpressions(body); | |||
| if (emittedBody.kind === SyntaxKind.ObjectLiteralExpression) { | |||
| const leftMostExpression = isExpression(emittedBody) ? getLeftmostExpression(emittedBody) : undefined; | |||
There was a problem hiding this comment.
I think this could just be:
if (!isBlock(body) && getLeftmostExpression(body).kind === SyntaxKind.ObjectLiteralExpresion)I suggest using !isBlock(body) here as there are fewer comparisons necessary than a full isExpression test.
Fix #14895