Static initializers may refer to later static methods #15010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static methods are created before static property initializers run, so static property initializers may refer to static methods. This was not allowed previously.
mhegazy
approved these changes
Apr 4, 2017
alexeagle
reviewed
Apr 4, 2017
| @@ -0,0 +1,14 @@ | |||
| class X { | |||
There was a problem hiding this comment.
The bug can also be observed on non-statics:
class Y {
a = "" + this.b;
b = "";
}
I'm not sure if your fix handles this case as well.
There was a problem hiding this comment.
this.b is undefined in the expression "" + this.b, even though its initial value is supposed to be "". I think we want to error in this case.
sandersn
deleted the
static-initialisers-can-refer-to-later-static-methods
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static methods are created before static property initializers run, so static property initializers may refer to static methods. This was not allowed previously.
Fixes #14312