Fix canvas getContext signature in lib/lib.dom.d.ts #15498
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to
https://developer.mozilla.org/en/docs/Web/API/HTMLCanvasElement/getConte
xt, it only returns
null if the context identifier is not supported
(i.e. not “2d” | "webgl" | "experimental-webgl”, when new non-standard
renderers are omitted).
It used to be that way, but was changed part of this (huge) commit, 1c9df84
I cannot find the originating commit in the PR: #9697 but it must be somewhere (my git skills are average).
This fix might make some people happy: this error generates tons of
useless and annoying non-null
!
type casts when working with canvases.'Bug' or 'Accepting PRs' or is in the Community milestone
master
branchjake runtests
locally