Skip to content

Disallow optional destructured parameters in implementation signatures. #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 16, 2015
Merged

Disallow optional destructured parameters in implementation signatures. #1676

merged 3 commits into from
Jan 16, 2015

Conversation

DanielRosenwasser
Copy link
Member

Fixes #1542.

@JsonFreeman
Copy link
Contributor

👍

2 similar comments
@sheetalkamat
Copy link
Member

👍

@mhegazy
Copy link
Contributor

mhegazy commented Jan 15, 2015

👍

DanielRosenwasser added a commit that referenced this pull request Jan 16, 2015
@DanielRosenwasser
Merge pull request #1676 from Microsoft/disallowOptionalBindingParame…
5bcb52f 
…ters

Disallow optional destructured parameters in implementation signatures.
@DanielRosenwasser DanielRosenwasser merged commit 5bcb52f into master Jan 16, 2015
@DanielRosenwasser DanielRosenwasser deleted the disallowOptionalBindingParameters branch January 16, 2015 00:55
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parameters with binding patterns should not be allowed to be optional
5 participants
@DanielRosenwasser @JsonFreeman @sheetalkamat @mhegazy @msftclas