Simplify server logger

[ghost]

Just have group instead of separate startGroup and endGroup.
Consolidate all noop test loggers.
Don't expose msg.

[sandersn]

The refactor looks solid although perhaps somebody else who is familiar with the server code should also review.

[sandersn]

Can you remove the count updating responsibility from printProjects and replace it with const counter = this.externalProjects.length + this.configuredProjects.length + this.inferredProjects.length. Then printProjects can be lifted out of this function entirely.

[rbuckton]

@sandersn, counter is used on line 948, though its still feasible to do something like:

function printProjects(projects: Project[], counter: number) {
  for (const project of projects) {
    ...
    counter++;
  }
  return counter;
}

And then use it like this:

let counter = 0;
counter = printProjects(this.externalProjects, counter);
counter = printProjects(this.configuredProjects, counter);
printProjects(this.inferredProjects, counter);

[rbuckton]

@sandersn, counter is used on line 948, though its still feasible to do something like:

function printProjects(projects: Project[], counter: number) {
  for (const project of projects) {
    ...
    counter++;
  }
  return counter;
}

And then use it like this:

let counter = 0;
counter = printProjects(this.externalProjects, counter);
counter = printProjects(this.configuredProjects, counter);
printProjects(this.inferredProjects, counter);

[rbuckton]

Could we instead turn Msg into a string enum? That would allow us to continue to find all references if necessary.

[rbuckton]

Why not turn this into a string enum?

[ghost]

There should only be one reference to each kind of message -- one each in perftrc(), info(), and err().

[rbuckton]

Odd. It looks like Travis caught an error due to an invalid cast, but Jenkins didn't.

[ghost]

I think the validity of the cast recently changed, so it might have to do with the TypeScript versions they're using.

[sandersn]

Yeah, I just saw it locally after merging from master.

[ghost]

Fix is already in. #17685