Skip to content

Added localization instructions to CONTRIBUTING.md #20451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2018
Merged

Added localization instructions to CONTRIBUTING.md #20451

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e2c4da8
Added localization instructions to CONTRIBUTING.md
Dec 4, 2017
b75c990
Corrected mention of generated ts file
Dec 4, 2017
22195dc
Mentioned coding guidelines
Dec 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,3 +183,8 @@ jake baseline-accept
```

to establish the new baselines as the desired behavior. This will change the files in `tests\baselines\reference`, which should be included as part of your commit. It's important to carefully validate changes in the baselines.

## Localization

All strings the user may see are stored in [`diagnosticMessages.json`](./src/compiler/diagnosticMessages.json).
If you make changes to it, run `jake generate-diagnostics` to push them to the generated localization and definition files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i do not think the last line is accurate.. jake generate-diagnostics just generates a .ts file that .src\compiler\diagnosticInformationMap.generated.ts that makes the diagnostic messages properties on the Diagnostics, with property names generated from their text.