Skip to content

Use CRLF in our code, not LF. #2187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2015
Merged

Use CRLF in our code, not LF. #2187

merged 2 commits into from
Mar 2, 2015

Conversation

CyrusNajmabadi
Copy link
Contributor

No description provided.

CyrusNajmabadi added a commit that referenced this pull request Mar 2, 2015
@CyrusNajmabadi
Merge pull request #2187 from Microsoft/CRLF
18b7257 
Use CRLF in our code, not LF.
@CyrusNajmabadi CyrusNajmabadi merged commit 18b7257 into master Mar 2, 2015
@CyrusNajmabadi CyrusNajmabadi deleted the CRLF branch March 2, 2015 23:15
@ctaggart
Copy link
Contributor

ctaggart commented Mar 3, 2015

👎
A good way to enforce normalized line endings is using a .gitattributes file. If you ever decided to use a .gitattributes file to enforce line endings, Git will make them LF in the repository. It is better to just to ditch CRLF when doing cross platform stuff.

@basarat
Copy link
Contributor

basarat commented Mar 3, 2015

They might potentially want mixed line endings for tests. Not sure though.

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrusNajmabadi @ctaggart @basarat @msftclas