Skip to content

Fix watch to honor tsconfig.json setting #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2015
Merged

Fix watch to honor tsconfig.json setting #2222

merged 1 commit into from
Mar 6, 2015

Conversation

billti
Copy link
Member

@billti billti commented Mar 6, 2015

Currently if you have {"watch": true} set in your compilerOptions in tsconfig.json it is ignored, as only the command-line watch setting is checked. Thus when you run just "tsc" on the command line it simply runs and exits. With the change the config setting is honored.

@DanielRosenwasser
Copy link
Member

👍

Any ideas if we use commandLine.options anywhere else? If so, we may need to change those too.

@mhegazy
Copy link
Contributor

mhegazy commented Mar 6, 2015

👍

billti added a commit that referenced this pull request Mar 6, 2015
Fix watch to honor tsconfig.json setting
@billti billti merged commit 0ea31c3 into microsoft:master Mar 6, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants