Remove redundant primitive types from intersections #23751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
approved these changes
Apr 28, 2018
| @@ -0,0 +1,15 @@ | |||
| // @strict | |||
There was a problem hiding this comment.
// @strict: true
This isn't setting any compiler options as is and becomes just a comment in the output. Though I guess it's heartening to know that nothing in this change actually relies on strict. 😛
There was a problem hiding this comment.
I don't think so. We have hundreds of tests that include // @strict: true and they definitely behave differently if you remove the comment.
There was a problem hiding this comment.
....this comment isn't // @strict: true, it's just // @strict. This comment does nothing.
kpdonn
reviewed
Apr 28, 2018
src/compiler/checker.ts
Outdated
| for (const type of types) { | ||
| includes = addTypeToIntersection(typeSet, includes, getRegularTypeOfLiteralType(type)); | ||
| } | ||
| return includes; | ||
| } | ||
|
|
||
| function removeRedundantPrimtiveTypes(types: Type[], includes: TypeFlags) { |
There was a problem hiding this comment.
Typo: should be removeRedundantPrimitiveTypes
mhegazy
approved these changes
Apr 28, 2018
This was referenced Apr 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes primitive types
string,number, andsymbolfrom intersections that also contain literal types from the same domain. For examplestring & 'a'is reduced to just'a'. Likewise,10 | numberis reduced to just10.The PR eliminates the
TypeIncludesenum from the type checker in favor of just usingTypeFlags. This allows us to more efficiently compute the combined flags during the construction of a union or intersection type.