Skip to content

Revert #26360: Don't error on destructure of private property with computed property syntax #26625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ajafff
Copy link
Contributor

@ajafff ajafff commented Aug 23, 2018

The conclusion of #26572 was to not suppress accessibility errors on destructuring assignment with computed name. For consistency this should also apply to destructuring binding properties.

@RyanCavanaugh RyanCavanaugh merged commit b5998d9 into microsoft:master Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants