Housekeeping: Fix equalOwnProperties #26794
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
equalOwnProperties()
would incorrectly report two map-like objects as equal in the case where a property defined inleft
was not defined inright
and whose value was considered "equal" to undefined by the equalityComparer.This bug was found by an alert on LGTM.com
I've added unit tests that check around this functionality, which fail before the fix, and succeed after the fix commit.
Before 2c41d8b:
After 2c41d8b: