Capture 'arguments' in arrow functions in pre-ES6 targets #2764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arguments' conflict sites.
| @@ -1419,7 +1419,7 @@ | |||
| "category": "Error", | |||
| "code": 2495 | |||
| }, | |||
| "The 'arguments' object cannot be referenced in an arrow function. Consider using a standard function expression.": { | |||
| "The 'arguments' object cannot be referenced in an arrow function below ES6. Consider using a standard function expression.": { | |||
There was a problem hiding this comment.
Just say "in ES3 or ES5"
|
@DanielRosenwasser we probably should close this now. |
|
Okay :( |
|
🌷 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should only apply to ES3 & ES5.
When an identifier named
argumentsis used in an arrow function, and can be resolved in some contained scope, we will captureargumentsas_argumentsif necessary and use_argumentsat every use-site.Resolves #2430.
I recommend just looking at the files-changed view. Quite a bit changed between commits.