Fix circular mapped type instantiations for arrays and tuples #27911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahejlsberg
requested review from
DanielRosenwasser,
RyanCavanaugh and
sandersn
sandersn
reviewed
Oct 15, 2018
| !!! error TS2322: Type '{ a: number; }' is not assignable to type '{ a?: undefined; b?: undefined; }'. | ||
| !!! error TS2322: Types of property 'a' are incompatible. | ||
| !!! error TS2322: Type 'number' is not assignable to type 'undefined'. | ||
| !!! error TS2322: Type '{ a: number; }' is not assignable to type '{ a: number; b: number; }'. |
There was a problem hiding this comment.
any idea why this changes? I don't see any mapped types here.
There was a problem hiding this comment.
Never mind, didn't see the change to discriminant types.
sandersn
reviewed
Oct 15, 2018
| @@ -14212,12 +14222,26 @@ namespace ts { | |||
| return undefined; | |||
| } | |||
|
|
|||
| function isDiscriminantType(type: Type): boolean { | |||
There was a problem hiding this comment.
this seems unrelated to the bug fix in the PR description
sandersn
reviewed
Oct 15, 2018
| } | ||
| let combined = 0; | ||
| for (const t of (<UnionType>type).types) combined |= t.flags; | ||
| if (combined & TypeFlags.Unit && !(combined & TypeFlags.Instantiable)) { |
There was a problem hiding this comment.
what happens if you have two two non-unit types? Should that still be discriminable?
There was a problem hiding this comment.
I'm pretty sure this change isn't supposed to be here, since it's #27695
|
I accidentally based this PR on the |
sandersn
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapped types can circularly reference themselves (because member resolution is deferred), but array and tuple type instantiations cannot. This causes an issue when a circular homomorphic mapped type is instantiated for an array or tuple type as we now create array and tuple instantiations for such mappings (see #26063). With is PR we quickly detect and stop the runaway recursion that can occur by substituting
errorTypefor the instantiation. We would eventually do this after 50 levels of nested instantiations, but exponential recursive fan-out could keep us from ever getting there.Fixes #27881.