add refactoring: inline local variable #28522
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't use default without export anyway
apparently, nodes do not have unique id in test environment
|
Ignore above comment, I assumed that in the test environment all nodes had unique ids, which is apparently not the case. |
|
@D0nGiovanni looks like not many updates here in a while - I'm going to close for housekeeping but this PR does look like something that is decently close to being mergeable. If you'd like to open a fresh PR to continue (maybe squash up those commits and address the merge conflicts) we can have someone try to help out with the last few issues. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18459
I've run into a problem though. If I invoke the refactoring in a development instance, it works fine. The tests fail for some reason that is beyond me. I've managed to narrow it down to my own function named
getReferencesInScope. Somehow, the test environment can't populate the array it is supposed to return. I had to use this function, because the compiler internalFindAllReferences.Core.eachSymbolReferenceInFileonly ever returns one reference and I didn't find any other solution that took care of my problem.