Remove unused (and sometimes broken) targets and scripts #30054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
requested review from
DanielRosenwasser,
rbuckton,
RyanCavanaugh and
sandersn
rbuckton
approved these changes
Mar 8, 2019
There was a problem hiding this comment.
I would check with @sheetalkamat and @sandersn to make sure they are not using the runtests-browser task.
|
@sandersn hasn't been using it for awhile, and I can only assume @sheetalkamat hasn't been either since it hasn't been able to run successfully due to harness changes for months ❤️ |
TimvdLippe
added a commit
to TimvdLippe/TypeScript
that referenced
this pull request
May 19, 2020
The gulp tasks were removed in microsoft#30054, but the contributing guidelines weren't updated accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runtests-browseris broken and doesn't run (we have some stuff in the harness the breaks it). Unless we like it a lot and want to fix it (and ideally add it so CI somehow so we know if it is broken by a change), I'm removing it.perf-tscseems unused - nowadays we collect our perf measures either with profilers directly or with thediagnosticsandextendedDiagnosticsflags to plain tsc (both of which have way to distinguish IO time).createBenchmarkscript is broken and doesn't compile.iorscript is useless with the new RWC baseline format we've used for the last year - every input file is already loose, so there's no need for an inspection tool.parallel-lintis unused.types/mochais unused since we updated the real mocha awhile ago.tests/test.batseems... pointless? No clue why it was there.I looked at
errorCheckas well, but that seems useful - like the rest of our useful scripts, it should probably be integrated into CI.