add stronger typings for Object.keys
#30314
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object.keys
is currently typed as outputtingstring[]
which is technically correct but causes issues when you forxample want to use the key with the original object if that object does not have an index signature.This is a bit annoying as
key
can only be a valid index offoo
but TS won't let you use it as such.Using this PR the above code works as
key
has the typekeyof foo
which is usable to indexfoo
.I have to apologise as the tests aren't passing at the moment. I'm struggling to see where they are failing and could do with some help. I also can't sign in to cla.opensource.microsoft.com to sign the CLA.