Skip to content

Include conditional types in top-level type parameter check #32260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 9, 2019

Conversation

ahejlsberg
Copy link
Member

Fixes #32169.

@ahejlsberg ahejlsberg requested a review from RyanCavanaugh July 5, 2019 02:29
@ahejlsberg ahejlsberg added this to the TypeScript 3.6.0 milestone Jul 5, 2019
@ahejlsberg
Copy link
Member Author

@typescript-bot run dt
@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 5, 2019

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 0d99292. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 5, 2019

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 0d99292. You can monitor the build here. It should now contribute to this PR's status checks.

@ahejlsberg
Copy link
Member Author

No changes in RWC baselines compared to master (all errors are preexisting conditions).

@ahejlsberg ahejlsberg merged commit b0f050f into master Jul 9, 2019
@ahejlsberg ahejlsberg deleted the fix32169 branch July 9, 2019 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic literal marker not obeyed for unknown and {}
3 participants