Change to missing file watcher on linux and darwin explicitly to avoid watching deleted inode #32745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d watching deleted inode
sheetalkamat
requested review from
orta,
sandersn,
weswigham,
andrewbranch,
rbuckton and
RyanCavanaugh
sheetalkamat
force-pushed
the
fsWatchInode
branch
from
55f54e9 to
8cf8eb1
Compare
sandersn
requested changes
Aug 8, 2019
Co-Authored-By: Nathan Shively-Sanders <[email protected]>
Co-Authored-By: Nathan Shively-Sanders <[email protected]>
sandersn
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially fixes issue with #32033 wherein
npm iwas not recognized because we were still watching deletednode_modulesinode for changes in directory.This does not fix the interruptions to intellisense while
npm installis going on. That has more to do with recursive watches and that would be handled separately.