Detect circular instantiated types #3316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (type.flags & TypeFlags.Reference && depth >= 10) { | ||
| let target = (<TypeReference>type).target; | ||
| if (type.flags & (TypeFlags.Reference | TypeFlags.Instantiated) && depth >= 10) { | ||
| let symbol = type.symbol; |
There was a problem hiding this comment.
I don't think this is necessary because you only refer to symbol once
There was a problem hiding this comment.
Not sure what you mean. It is referenced in a loop that will run at least 10 times (as we known depth >= 10).
There was a problem hiding this comment.
I mean just once lexically. I didn't know the runtime references count individually wrt to local vars.
|
👍 |
Conflicts: src/compiler/checker.ts src/compiler/types.ts
ahejlsberg
added a commit
that referenced
this pull request
Jun 3, 2015
Detect circular instantiated types
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3309 (and revises fix for #3237).
This PR switches our
isDeeplyNestedGenericfunction to track both type references and instantiated anonymous types. The key change is that we use the symbol associated with the type as the tracked identity (which is always the symbol of the type being instantiated). We likewise now use symbols to track cyclic anonymous types in the type-to-string logic.The PR removes the anonymous type instantiation caching implemented in #3239 as it is no longer necessary.