-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Elevate mapped types over type parameters in the same way as naked type parameters in intersection inference prioritization #33223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@typescript-bot run dt |
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 8bc3d76. You can monitor the build here. It should now contribute to this PR's status checks. |
Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 8bc3d76. You can monitor the build here. It should now contribute to this PR's status checks. |
Heya @weswigham, I've started to run the tarball bundle task on this PR at 8bc3d76. You can monitor the build here. It should now contribute to this PR's status checks. |
Heya @weswigham, I've started to run the extended test suite on this PR at 8bc3d76. You can monitor the build here. It should now contribute to this PR's status checks. |
Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running |
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
|
And RWC and DT are both clean, nice. |
…pe parameters in intersection inference prioritization
8bc3d76
to
a2b3af2
Compare
@typescript-bot cherry-pick this into release-3.6 |
Component commits: a2b3af2 Elevate mapped types over type parameters in the same way as naked type parameters in intersection inference prioritization
Hey @weswigham, I've opened #33250 for you. |
Component commits: a2b3af2 Elevate mapped types over type parameters in the same way as naked type parameters in intersection inference prioritization
Fixes #33164
We should probably investigate if in the other places in inference where we check
getInferenceInfoForType
we should also be checking in a passthru-type way for homomrphic mapped types over a targeted type parameter, as I do here in the intersection case.