Skip to content

Never normalize end-of-lines on clone/commit. #3324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2015
Merged

Never normalize end-of-lines on clone/commit. #3324

merged 1 commit into from
Jun 2, 2015

Conversation

MicahZoltu
Copy link
Contributor

This change should remove the requirement that people have to set a global git config flag in order for the tests to pass on clean clone.

Verification steps:

  1. delete local repo
  2. clone repo
  3. build
  4. run tests
  5. make code change
  6. verify git diff doesn't see file as binary (you should see an actual diff)

@msftclas
Copy link

Hi @Zoltu, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@DanielRosenwasser
Copy link
Member

I'm okay with this. I'll give it a try later just to confirm it has correct behavior.

@msftclas
Copy link

msftclas commented Jun 1, 2015

@Zoltu, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@DanielRosenwasser
Copy link
Member

👍

DanielRosenwasser added a commit that referenced this pull request Jun 2, 2015
Never normalize end-of-lines on clone/commit.
@DanielRosenwasser DanielRosenwasser merged commit c25418a into microsoft:master Jun 2, 2015
@DanielRosenwasser
Copy link
Member

Thanks @Zoltu!

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants