Skip to content

fix #32843 : evaluate right scope when checked if all type parameter … #33320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2020
Merged

fix #32843 : evaluate right scope when checked if all type parameter … #33320

merged 1 commit into from
Mar 31, 2020
+157 −1

Conversation

pr1tkin
Copy link
Contributor

@pr1tkin pr1tkin commented Sep 9, 2019

Fixes #32843

fix microsoft#32843 : evaluate right scope when checked if all type p…
ca324a0 
…arameter are unused for jsdoc `@template`
@msftclas
Copy link

msftclas commented Sep 9, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@sandersn sandersn added the For Backlog Bug PRs that fix a backlog bug label Feb 1, 2020
andrewbranch
andrewbranch approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks right. Thanks!

@andrewbranch andrewbranch merged commit 9c4cbd6 into microsoft:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

@elibarzilay elibarzilay Awaiting requested review from elibarzilay

Assignees

@andrewbranch andrewbranch

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unused type parameter message is wrong for jsdoc @template
4 participants
@pr1tkin @msftclas @andrewbranch @sandersn