🤖 User test baselines have changed #33411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
force-pushed
the
user-update-Microsoft-20190805
branch
from
4cb547f to
408a6c2
Compare
weswigham
reviewed
Sep 13, 2019
| node_modules/@jimp/core/index.d.ts(255,42): error TS2344: Type 'T' does not satisfy the constraint 'WellFormedPlugin<Image>'. | ||
| Type 'JimpType<Image> | undefined' is not assignable to type 'WellFormedPlugin<Image>'. | ||
| Type 'undefined' is not assignable to type 'WellFormedPlugin<Image>'. | ||
| index.ts(1,23): error TS2307: Cannot find module 'jimp'. |
There was a problem hiding this comment.
jimp-dev/jimp#792 yeah they're still... trying. XD
weswigham
reviewed
Sep 13, 2019
| {"type":"warning","data":"../package.json: No license field"} | ||
| {"type":"warning","data":"[email protected]: No license field"} | ||
| [XX:XX:XX] 'compile' errored after ?s | ||
| [XX:XX:XX] TypeError: Cannot read property 'text' of undefined |
There was a problem hiding this comment.
@mjbvz is the vscode build broken? This error stack doesn't include the TS compiler. o.O
There was a problem hiding this comment.
I think master was broken earlier today but it should be fixed now
weswigham
reviewed
Sep 13, 2019
| @@ -0,0 +1,10 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| lib/Compilation.js(575,5): error TS2322: Type 'number | "toString" | "valueOf" | "charAt" | "charCodeAt" | "concat" | "indexOf" | "lastIndexOf" | "localeCompare" | "match" | "replace" | "search" | "slice" | "split" | "substring" | ... 29 more ... | "trimRight"' is not assignable to type 'string'. | |||
There was a problem hiding this comment.
OK, so this is broken because of webpack. They wrote /** @typedef {keyof LogType} LogTypeEnum */. LogType is string. That is keyof string. That is wrong. They need to write, instead, /** @typedef {keyof typeof LogType} LogTypeEnum */. Not really sure why this doesn't error in however they're testing their types, but it should.
cc @sokra just so yall know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh