Skip to content

Block completion when in the flags of a regular expression #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 2, 2015

Conversation

DanielRosenwasser
Copy link
Member

Fixes #3339.

// newline separating us from the regex flags.

goTo.marker();
verify.not.completionListIsEmpty();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would search for x here, just to be sure.

@mhegazy
Copy link
Contributor

mhegazy commented Jun 2, 2015

WOOT 💨
👍

DanielRosenwasser added a commit that referenced this pull request Jun 2, 2015
Block completion when in the flags of a regular expression
@DanielRosenwasser DanielRosenwasser merged commit 4d8d1cc into master Jun 2, 2015
@DanielRosenwasser DanielRosenwasser deleted the irregularExpressionCompletion branch June 2, 2015 21:15
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should not give suggestion at the position of regular expression flags.
3 participants