Skip to content

Fix issues caused by reachability analysis of this.foo(...) like calls. #33598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2019
Merged

Fix issues caused by reachability analysis of this.foo(...) like calls. #33598

merged 3 commits into from
Sep 25, 2019

Conversation

ahejlsberg
Copy link
Member

Fixes #33582.

@ahejlsberg
Copy link
Member Author

@typescript-bot run dt
@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 25, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the perf test suite on this PR at 0d4e594. You can monitor the build here. It should now contribute to this PR's status checks.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 25, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 0d4e594. You can monitor the build here. It should now contribute to this PR's status checks.

@ahejlsberg ahejlsberg requested a review from sandersn September 25, 2019 16:37
@typescript-bot
Copy link
Collaborator

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..33598

Metric master 33598 Delta Best Worst
Angular - node (v12.1.0, x64)
Memory used 331,767k (± 0.02%) 332,027k (± 0.07%) +260k (+ 0.08%) 331,174k 332,382k
Parse Time 1.56s (± 0.59%) 1.57s (± 0.80%) +0.01s (+ 0.58%) 1.55s 1.60s
Bind Time 0.81s (± 0.45%) 0.80s (± 0.72%) -0.00s (- 0.37%) 0.79s 0.82s
Check Time 4.37s (± 0.52%) 4.38s (± 0.48%) +0.02s (+ 0.37%) 4.34s 4.42s
Emit Time 5.30s (± 2.16%) 5.28s (± 0.84%) -0.02s (- 0.38%) 5.21s 5.42s
Total Time 12.03s (± 1.03%) 12.03s (± 0.39%) +0.00s (+ 0.01%) 11.95s 12.19s
Monaco - node (v12.1.0, x64)
Memory used 346,945k (± 0.02%) 346,969k (± 0.02%) +24k (+ 0.01%) 346,852k 347,093k
Parse Time 1.22s (± 0.73%) 1.22s (± 0.61%) -0.00s (- 0.08%) 1.21s 1.24s
Bind Time 0.69s (± 0.69%) 0.68s (± 1.11%) -0.00s (- 0.29%) 0.67s 0.70s
Check Time 4.40s (± 0.63%) 4.36s (± 0.41%) -0.04s (- 0.95%) 4.33s 4.39s
Emit Time 2.87s (± 0.79%) 2.87s (± 0.57%) -0.01s (- 0.21%) 2.83s 2.90s
Total Time 9.19s (± 0.49%) 9.13s (± 0.28%) -0.05s (- 0.58%) 9.08s 9.18s
TFS - node (v12.1.0, x64)
Memory used 303,641k (± 0.02%) 303,682k (± 0.02%) +41k (+ 0.01%) 303,542k 303,787k
Parse Time 0.95s (± 0.68%) 0.95s (± 0.74%) -0.00s (- 0.32%) 0.93s 0.96s
Bind Time 0.64s (± 1.05%) 0.64s (± 0.77%) -0.00s (- 0.16%) 0.63s 0.65s
Check Time 3.98s (± 0.55%) 3.96s (± 0.51%) -0.02s (- 0.48%) 3.93s 4.01s
Emit Time 2.97s (± 0.74%) 2.99s (± 0.95%) +0.01s (+ 0.44%) 2.90s 3.04s
Total Time 8.54s (± 0.46%) 8.53s (± 0.47%) -0.01s (- 0.15%) 8.43s 8.63s
Angular - node (v8.9.0, x64)
Memory used 350,399k (± 0.02%) 350,732k (± 0.02%) +333k (+ 0.09%) 350,627k 350,858k
Parse Time 2.11s (± 0.39%) 2.11s (± 0.63%) +0.00s (+ 0.14%) 2.07s 2.14s
Bind Time 0.84s (± 0.70%) 0.85s (± 0.58%) +0.00s (+ 0.24%) 0.84s 0.86s
Check Time 5.25s (± 0.52%) 5.23s (± 0.54%) -0.02s (- 0.42%) 5.19s 5.32s
Emit Time 6.00s (± 0.79%) 6.03s (± 0.92%) +0.03s (+ 0.42%) 5.95s 6.20s
Total Time 14.21s (± 0.38%) 14.21s (± 0.44%) +0.00s (+ 0.03%) 14.06s 14.35s
Monaco - node (v8.9.0, x64)
Memory used 364,633k (± 0.02%) 364,613k (± 0.01%) -20k (- 0.01%) 364,538k 364,690k
Parse Time 1.57s (± 0.82%) 1.56s (± 0.37%) -0.00s (- 0.26%) 1.55s 1.58s
Bind Time 0.89s (± 1.02%) 0.89s (± 0.83%) -0.00s (- 0.11%) 0.88s 0.91s
Check Time 5.29s (± 1.20%) 5.26s (± 1.62%) -0.03s (- 0.53%) 5.16s 5.44s
Emit Time 3.14s (± 4.62%) 3.21s (± 4.04%) +0.07s (+ 2.36%) 2.93s 3.35s
Total Time 10.88s (± 0.83%) 10.93s (± 0.44%) +0.05s (+ 0.44%) 10.82s 10.99s
TFS - node (v8.9.0, x64)
Memory used 319,897k (± 0.02%) 319,896k (± 0.01%) -1k (- 0.00%) 319,793k 319,937k
Parse Time 1.26s (± 0.46%) 1.26s (± 0.44%) -0.00s (- 0.08%) 1.25s 1.27s
Bind Time 0.71s (± 6.60%) 0.74s (± 7.31%) +0.03s (+ 3.80%) 0.66s 0.83s
Check Time 4.57s (± 1.31%) 4.49s (± 1.36%) -0.08s (- 1.64%) 4.39s 4.63s
Emit Time 3.10s (± 0.36%) 3.08s (± 1.07%) -0.02s (- 0.61%) 2.98s 3.14s
Total Time 9.64s (± 0.27%) 9.57s (± 0.42%) -0.07s (- 0.68%) 9.46s 9.67s
Angular - node (v8.9.0, x86)
Memory used 198,371k (± 0.02%) 198,536k (± 0.02%) +165k (+ 0.08%) 198,488k 198,621k
Parse Time 2.04s (± 0.49%) 2.04s (± 0.94%) -0.00s (- 0.10%) 2.00s 2.08s
Bind Time 0.96s (± 0.69%) 0.96s (± 0.86%) +0.00s (+ 0.10%) 0.95s 0.99s
Check Time 4.77s (± 0.42%) 4.73s (± 0.50%) -0.04s (- 0.90%) 4.68s 4.78s
Emit Time 5.72s (± 1.14%) 5.72s (± 0.68%) -0.00s (- 0.07%) 5.62s 5.80s
Total Time 13.49s (± 0.56%) 13.45s (± 0.34%) -0.04s (- 0.31%) 13.31s 13.56s
Monaco - node (v8.9.0, x86)
Memory used 203,750k (± 0.01%) 203,733k (± 0.01%) -16k (- 0.01%) 203,647k 203,779k
Parse Time 1.61s (± 0.65%) 1.62s (± 0.37%) +0.00s (+ 0.19%) 1.60s 1.63s
Bind Time 0.72s (± 1.11%) 0.72s (± 0.51%) -0.01s (- 0.83%) 0.71s 0.72s
Check Time 5.07s (± 1.79%) 5.02s (± 0.46%) -0.05s (- 0.97%) 4.97s 5.07s
Emit Time 3.08s (± 2.87%) 3.16s (± 0.74%) +0.08s (+ 2.50%) 3.12s 3.20s
Total Time 10.48s (± 0.16%) 10.51s (± 0.21%) +0.02s (+ 0.23%) 10.44s 10.56s
TFS - node (v8.9.0, x86)
Memory used 179,759k (± 0.01%) 179,769k (± 0.02%) +10k (+ 0.01%) 179,705k 179,864k
Parse Time 1.32s (± 0.77%) 1.31s (± 0.84%) -0.01s (- 0.83%) 1.29s 1.34s
Bind Time 0.64s (± 1.32%) 0.64s (± 1.41%) -0.00s (- 0.63%) 0.63s 0.67s
Check Time 4.37s (± 0.56%) 4.37s (± 0.53%) 0.00s ( 0.00%) 4.33s 4.42s
Emit Time 2.87s (± 0.84%) 2.86s (± 0.83%) -0.01s (- 0.49%) 2.80s 2.91s
Total Time 9.20s (± 0.36%) 9.18s (± 0.47%) -0.03s (- 0.29%) 9.05s 9.26s
Angular - node (v9.0.0, x64)
Memory used 349,993k (± 0.02%) 350,455k (± 0.01%) +462k (+ 0.13%) 350,343k 350,593k
Parse Time 1.82s (± 0.37%) 1.83s (± 0.45%) +0.01s (+ 0.55%) 1.81s 1.85s
Bind Time 0.79s (± 0.74%) 0.79s (± 1.03%) +0.01s (+ 0.76%) 0.78s 0.82s
Check Time 5.03s (± 0.86%) 5.00s (± 0.62%) -0.02s (- 0.46%) 4.92s 5.05s
Emit Time 5.77s (± 1.12%) 5.83s (± 0.66%) +0.05s (+ 0.94%) 5.78s 5.94s
Total Time 13.40s (± 0.61%) 13.45s (± 0.43%) +0.05s (+ 0.34%) 13.34s 13.60s
Monaco - node (v9.0.0, x64)
Memory used 364,313k (± 0.02%) 364,352k (± 0.01%) +39k (+ 0.01%) 364,215k 364,426k
Parse Time 1.32s (± 0.53%) 1.31s (± 0.67%) -0.01s (- 0.61%) 1.30s 1.33s
Bind Time 0.85s (± 1.14%) 0.85s (± 1.37%) -0.00s (- 0.35%) 0.83s 0.88s
Check Time 5.16s (± 1.69%) 5.25s (± 1.41%) +0.09s (+ 1.76%) 5.06s 5.38s
Emit Time 3.16s (± 5.07%) 2.99s (± 4.47%) -0.17s (- 5.53%) 2.87s 3.35s
Total Time 10.49s (± 0.82%) 10.40s (± 0.78%) -0.10s (- 0.93%) 10.28s 10.61s
TFS - node (v9.0.0, x64)
Memory used 319,562k (± 0.01%) 319,583k (± 0.01%) +20k (+ 0.01%) 319,474k 319,631k
Parse Time 1.04s (± 0.55%) 1.04s (± 0.66%) -0.00s (- 0.38%) 1.02s 1.05s
Bind Time 0.63s (± 0.95%) 0.63s (± 0.54%) +0.00s (+ 0.16%) 0.62s 0.63s
Check Time 4.56s (± 0.35%) 4.54s (± 0.63%) -0.02s (- 0.46%) 4.46s 4.58s
Emit Time 3.20s (± 0.73%) 3.20s (± 0.80%) +0.01s (+ 0.19%) 3.12s 3.24s
Total Time 9.43s (± 0.31%) 9.40s (± 0.37%) -0.02s (- 0.22%) 9.34s 9.48s
Angular - node (v9.0.0, x86)
Memory used 198,553k (± 0.02%) 198,677k (± 0.04%) +124k (+ 0.06%) 198,530k 198,819k
Parse Time 1.72s (± 0.58%) 1.72s (± 0.47%) 0.00s ( 0.00%) 1.71s 1.74s
Bind Time 0.91s (± 0.89%) 0.91s (± 0.98%) +0.00s (+ 0.44%) 0.89s 0.93s
Check Time 4.44s (± 0.58%) 4.46s (± 0.85%) +0.02s (+ 0.56%) 4.39s 4.56s
Emit Time 5.53s (± 0.59%) 5.57s (± 1.24%) +0.04s (+ 0.74%) 5.43s 5.75s
Total Time 12.60s (± 0.36%) 12.68s (± 0.70%) +0.08s (+ 0.61%) 12.53s 12.89s
Monaco - node (v9.0.0, x86)
Memory used 203,798k (± 0.03%) 203,800k (± 0.01%) +2k (+ 0.00%) 203,740k 203,835k
Parse Time 1.35s (± 0.73%) 1.35s (± 1.01%) +0.00s (+ 0.30%) 1.33s 1.39s
Bind Time 0.65s (± 0.68%) 0.66s (± 1.72%) +0.01s (+ 1.53%) 0.65s 0.69s
Check Time 4.85s (± 0.59%) 4.86s (± 0.65%) +0.01s (+ 0.19%) 4.80s 4.94s
Emit Time 3.09s (± 0.48%) 3.09s (± 0.50%) -0.00s (- 0.13%) 3.05s 3.13s
Total Time 9.94s (± 0.43%) 9.96s (± 0.42%) +0.02s (+ 0.16%) 9.87s 10.07s
TFS - node (v9.0.0, x86)
Memory used 179,715k (± 0.02%) 179,738k (± 0.02%) +23k (+ 0.01%) 179,669k 179,837k
Parse Time 1.06s (± 0.75%) 1.07s (± 0.90%) +0.01s (+ 0.66%) 1.05s 1.09s
Bind Time 0.59s (± 0.84%) 0.59s (± 0.76%) +0.00s (+ 0.34%) 0.58s 0.60s
Check Time 4.29s (± 0.67%) 4.30s (± 0.58%) +0.02s (+ 0.44%) 4.25s 4.37s
Emit Time 2.78s (± 0.74%) 2.78s (± 0.98%) +0.00s (+ 0.04%) 2.73s 2.85s
Total Time 8.71s (± 0.42%) 8.74s (± 0.53%) +0.03s (+ 0.32%) 8.64s 8.82s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-161-generic
Architecturex64
Available Memory16 GB
Available Memory9 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
  • node (v9.0.0, x64)
  • node (v9.0.0, x86)
Scenarios
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Angular - node (v9.0.0, x64)
  • Angular - node (v9.0.0, x86)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • Monaco - node (v9.0.0, x64)
  • Monaco - node (v9.0.0, x86)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • TFS - node (v9.0.0, x64)
  • TFS - node (v9.0.0, x86)
Benchmark Name Iterations
Current 33598 10
Baseline master 10

@ahejlsberg ahejlsberg merged commit 75117ac into master Sep 25, 2019
@ahejlsberg ahejlsberg deleted the fix33582 branch September 25, 2019 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#32695 breaks aframe in DT
3 participants
@ahejlsberg @typescript-bot @sandersn