-
Notifications
You must be signed in to change notification settings - Fork 12.8k
JSX and as
operator
#3564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSX and as
operator
#3564
Changes from 14 commits
556cb70
a4045e5
6dfe3d7
195db03
f5336db
6d01a44
e34d8cd
fa198a5
2b44dca
bc9b53a
a5c44a3
46eb521
b0750c2
388e73f
2555344
e448d8b
c9a925e
16c8344
5bc10b9
b3ca009
65828c4
8180b7d
b1a05b8
306de4d
ce6f39e
042f1fc
634d35a
1d09c6e
3402f35
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -389,6 +389,17 @@ namespace ts { | |
No_base_constructor_has_the_specified_number_of_type_arguments: { code: 2508, category: DiagnosticCategory.Error, key: "No base constructor has the specified number of type arguments." }, | ||
Base_constructor_return_type_0_is_not_a_class_or_interface_type: { code: 2509, category: DiagnosticCategory.Error, key: "Base constructor return type '{0}' is not a class or interface type." }, | ||
Base_constructors_must_all_have_the_same_return_type: { code: 2510, category: DiagnosticCategory.Error, key: "Base constructors must all have the same return type." }, | ||
JSX_element_attributes_type_0_must_be_an_object_type: { code: 2600, category: DiagnosticCategory.Error, key: "JSX element attributes type '{0}' must be an object type." }, | ||
The_return_type_of_a_JSX_element_constructor_must_return_an_object_type: { code: 2601, category: DiagnosticCategory.Error, key: "The return type of a JSX element constructor must return an object type." }, | ||
The_global_type_JSX_Element_must_exist_when_using_JSX: { code: 2602, category: DiagnosticCategory.Error, key: "The global type 'JSX.Element' must exist when using JSX." }, | ||
Property_0_in_type_1_is_not_assignable_to_type_2: { code: 2603, category: DiagnosticCategory.Error, key: "Property '{0}' in type '{1}' is not assignable to type '{2}'" }, | ||
JSX_element_0_is_not_a_constructor_function: { code: 2604, category: DiagnosticCategory.Error, key: "JSX element '{0}' is not a constructor function." }, | ||
JSX_element_0_is_not_a_constructor_function_for_JSX_elements: { code: 2605, category: DiagnosticCategory.Error, key: "JSX element '{0}' is not a constructor function for JSX elements." }, | ||
Property_0_of_JSX_spread_attribute_is_not_assignable_to_target_property: { code: 2606, category: DiagnosticCategory.Error, key: "Property '{0}' of JSX spread attribute is not assignable to target property." }, | ||
JSX_element_class_does_not_support_attributes_because_it_does_not_have_a_0_property: { code: 2607, category: DiagnosticCategory.Error, key: "JSX element class does not support attributes because it does not have a '{0}' property" }, | ||
The_global_type_JSX_0_may_not_have_more_than_one_property: { code: 2608, category: DiagnosticCategory.Error, key: "The global type 'JSX.{0}' may not have more than one property" }, | ||
JSX_element_implicitly_has_type_any_because_no_interface_JSX_0_exists: { code: 2609, category: DiagnosticCategory.Error, key: "JSX element implicitly has type 'any' because no interface JSX.{0} exists" }, | ||
Cannot_emit_namespaced_JSX_elements_in_React: { code: 2650, category: DiagnosticCategory.Error, key: "Cannot emit namespaced JSX elements in React" }, | ||
Import_declaration_0_is_using_private_name_1: { code: 4000, category: DiagnosticCategory.Error, key: "Import declaration '{0}' is using private name '{1}'." }, | ||
Type_parameter_0_of_exported_class_has_or_is_using_private_name_1: { code: 4002, category: DiagnosticCategory.Error, key: "Type parameter '{0}' of exported class has or is using private name '{1}'." }, | ||
Type_parameter_0_of_exported_interface_has_or_is_using_private_name_1: { code: 4004, category: DiagnosticCategory.Error, key: "Type parameter '{0}' of exported interface has or is using private name '{1}'." }, | ||
|
@@ -531,6 +542,8 @@ namespace ts { | |
Specifies_the_end_of_line_sequence_to_be_used_when_emitting_files_Colon_CRLF_dos_or_LF_unix: { code: 6060, category: DiagnosticCategory.Message, key: "Specifies the end of line sequence to be used when emitting files: 'CRLF' (dos) or 'LF' (unix)." }, | ||
NEWLINE: { code: 6061, category: DiagnosticCategory.Message, key: "NEWLINE" }, | ||
Argument_for_newLine_option_must_be_CRLF_or_LF: { code: 6062, category: DiagnosticCategory.Error, key: "Argument for '--newLine' option must be 'CRLF' or 'LF'." }, | ||
Specifies_how_to_transform_JSX_syntax_during_compilation: { code: 6080, category: DiagnosticCategory.Message, key: "Specifies how to transform JSX syntax during compilation." }, | ||
Argument_for_jsx_must_be_preserve_or_react: { code: 6081, category: DiagnosticCategory.Message, key: "Argument for --jsx must be 'preserve' or 'react'." }, | ||
Option_experimentalDecorators_must_also_be_specified_when_option_emitDecoratorMetadata_is_specified: { code: 6064, category: DiagnosticCategory.Error, key: "Option 'experimentalDecorators' must also be specified when option 'emitDecoratorMetadata' is specified." }, | ||
Enables_experimental_support_for_ES7_decorators: { code: 6065, category: DiagnosticCategory.Message, key: "Enables experimental support for ES7 decorators." }, | ||
Enables_experimental_support_for_emitting_type_metadata_for_decorators: { code: 6066, category: DiagnosticCategory.Message, key: "Enables experimental support for emitting type metadata for decorators." }, | ||
|
@@ -569,5 +582,11 @@ namespace ts { | |
decorators_can_only_be_used_in_a_ts_file: { code: 8017, category: DiagnosticCategory.Error, key: "'decorators' can only be used in a .ts file." }, | ||
Only_identifiers_Slashqualified_names_with_optional_type_arguments_are_currently_supported_in_a_class_extends_clauses: { code: 9002, category: DiagnosticCategory.Error, key: "Only identifiers/qualified-names with optional type arguments are currently supported in a class 'extends' clauses." }, | ||
class_expressions_are_not_currently_supported: { code: 9003, category: DiagnosticCategory.Error, key: "'class' expressions are not currently supported." }, | ||
class_declarations_are_only_supported_directly_inside_a_module_or_as_a_top_level_declaration: { code: 9004, category: DiagnosticCategory.Error, key: "'class' declarations are only supported directly inside a module or as a top level declaration." }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't see this being used anywhere. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems to have been mismerged. Removed. |
||
JSX_attributes_must_only_be_assigned_a_non_empty_expression: { code: 17000, category: DiagnosticCategory.Error, key: "JSX attributes must only be assigned a non-empty 'expression'." }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should "expression" have single quotes around it? |
||
JSX_elements_cannot_have_multiple_attributes_with_the_same_name: { code: 17001, category: DiagnosticCategory.Error, key: "JSX elements cannot have multiple attributes with the same name." }, | ||
Expected_corresponding_JSX_closing_tag_for_0: { code: 17002, category: DiagnosticCategory.Error, key: "Expected corresponding JSX closing tag for '{0}'." }, | ||
JSX_attribute_expected: { code: 17003, category: DiagnosticCategory.Error, key: "JSX attribute expected." }, | ||
Cannot_use_JSX_unless_the_jsx_flag_is_provided: { code: 17004, category: DiagnosticCategory.Error, key: "Cannot use JSX unless the '--jsx' flag is provided." }, | ||
}; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -686,7 +686,7 @@ | |
"Experimental support for decorators is a feature that is subject to change in a future release. Specify '--experimentalDecorators' to remove this warning.": { | ||
"category": "Error", | ||
"code": 1219 | ||
}, | ||
}, | ||
"Generators are only available when targeting ECMAScript 6 or higher.": { | ||
"category": "Error", | ||
"code": 1220 | ||
|
@@ -1546,6 +1546,52 @@ | |
"code": 2510 | ||
}, | ||
|
||
"JSX element attributes type '{0}' must be an object type.": { | ||
"category": "Error", | ||
"code": 2600 | ||
}, | ||
"The return type of a JSX element constructor must return an object type.": { | ||
"category": "Error", | ||
"code": 2601 | ||
}, | ||
"The global type 'JSX.Element' must exist when using JSX.": { | ||
"category": "Error", | ||
"code": 2602 | ||
}, | ||
"Property '{0}' in type '{1}' is not assignable to type '{2}'": { | ||
"category": "Error", | ||
"code": 2603 | ||
}, | ||
"JSX element '{0}' is not a constructor function.": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if we could just get away with the following message and get rid of this one. I could see it either way. Also, should these be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed up. The following message is the head message for an assignability check so is phrased a bit differently |
||
"category": "Error", | ||
"code": 2604 | ||
}, | ||
"JSX element '{0}' is not a constructor function for JSX elements.": { | ||
"category": "Error", | ||
"code": 2605 | ||
}, | ||
"Property '{0}' of JSX spread attribute is not assignable to target property.": { | ||
"category": "Error", | ||
"code": 2606 | ||
}, | ||
"JSX element class does not support attributes because it does not have a '{0}' property": { | ||
"category": "Error", | ||
"code": 2607 | ||
}, | ||
"The global type 'JSX.{0}' may not have more than one property": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Put single quotes around There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't see what you're referring to? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I may be losing my mind; when I wrote that, I did not see the single quotes. |
||
"category": "Error", | ||
"code": 2608 | ||
}, | ||
"JSX element implicitly has type 'any' because no interface JSX.{0} exists": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Put single quotes around the Should this be by the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed & moved |
||
"category": "Error", | ||
"code": 2609 | ||
}, | ||
|
||
"Cannot emit namespaced JSX elements in React": { | ||
"category": "Error", | ||
"code": 2650 | ||
}, | ||
|
||
"Import declaration '{0}' is using private name '{1}'.": { | ||
"category": "Error", | ||
"code": 4000 | ||
|
@@ -1914,7 +1960,7 @@ | |
"category": "Error", | ||
"code": 5050 | ||
}, | ||
"Option 'inlineSources' can only be used when either option '--inlineSourceMap' or option '--sourceMap' is provided.": { | ||
"Option 'inlineSources' can only be used when either option '--inlineSourceMap' or option '--sourceMap' is provided.": { | ||
"category": "Error", | ||
"code": 5051 | ||
}, | ||
|
@@ -2107,14 +2153,22 @@ | |
"category": "Message", | ||
"code": 6060 | ||
}, | ||
"NEWLINE": { | ||
"category": "Message", | ||
"NEWLINE": { | ||
"category": "Message", | ||
"code": 6061 | ||
}, | ||
"Argument for '--newLine' option must be 'CRLF' or 'LF'.": { | ||
"category": "Error", | ||
"category": "Error", | ||
"code": 6062 | ||
}, | ||
"Specifies how to transform JSX syntax during compilation.": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should this be similar to
I had to pass some random value to know what was the possible values are. tsc --jsx random app.ts
message TS6081: Argument for '--jsx' must be 'preserve' or 'react'. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed. |
||
"category": "Message", | ||
"code": 6080 | ||
}, | ||
"Argument for --jsx must be 'preserve' or 'react'.": { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Single quotes around There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✔️ |
||
"category": "Message", | ||
"code": 6081 | ||
}, | ||
"Option 'experimentalDecorators' must also be specified when option 'emitDecoratorMetadata' is specified.": { | ||
"category": "Error", | ||
"code": 6064 | ||
|
@@ -2268,5 +2322,29 @@ | |
"'class' expressions are not currently supported.": { | ||
"category": "Error", | ||
"code": 9003 | ||
}, | ||
"'class' declarations are only supported directly inside a module or as a top level declaration.": { | ||
"category": "Error", | ||
"code": 9004 | ||
}, | ||
"JSX attributes must only be assigned a non-empty 'expression'.": { | ||
"category": "Error", | ||
"code": 17000 | ||
}, | ||
"JSX elements cannot have multiple attributes with the same name.": { | ||
"category": "Error", | ||
"code": 17001 | ||
}, | ||
"Expected corresponding JSX closing tag for '{0}'.": { | ||
"category": "Error", | ||
"code": 17002 | ||
}, | ||
"JSX attribute expected.": { | ||
"category": "Error", | ||
"code": 17003 | ||
}, | ||
"Cannot use JSX unless the '--jsx' flag is provided.": { | ||
"category": "Error", | ||
"code": 17004 | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let
s throughout this functionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️