Report time spent in updateGraph #35675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a response property indicating how much of the elapsed time (from `onMessage` to `doOutput`) was spent in `updateGraph` calls. If there's no `updateGraph` call, the property is undefined, to save space (with the downside that it's harder to tell whether a given telemetry event could have had the property). Fixes microsoft#34774
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @amcasey, @mjbvz, @minestarks for you. Feel free to loop in other consumers/maintainers if necessary |
|
Just to clarify - this reflects the time spent in updateGraph during a given request, regardless of whether or not that request actually triggered the updateGraph, right? |
|
@uniqueiniquity Yep |
|
Note to reviewers: this looks over-engineered for a single property because it used to be for two properties and I decided the second one needed more refinement than would fit in the 3.8 timeframe. |
amcasey
commented
Jan 7, 2020
RyanCavanaugh
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a response property indicating how much of the elapsed time (from
onMessagetodoOutput) was spent inupdateGraphcalls. If there'snoupdateGraphcall, the property is undefined, to save space (with the downside that it's harder to tell whether a given telemetry event could have had the property).Fixes #34774