Add base constraint completions for JSX attributes #35803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
requested review from
sheetalkamat,
DanielRosenwasser and
weswigham
weswigham
approved these changes
Dec 21, 2019
|
We can try to ask people to dogfood it, but I would say we'll have better luck with shipping it in the beta and asking partner teams to try it. |
|
Cool, let’s try it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes JSX completions work the same way as object literals as of #33937/#34855. Has the same tradeoffs discussed in #35702. @DanielRosenwasser, do you think we can try to get this in the hands of some real users to see how it feels?
Fixes #34957