Skip to content

Fix contextually typed object literal completions where the object being edited affects its own inference #36556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 31, 2020

Conversation

andrewbranch
Copy link
Member

This is Wes’s alternative to my PR #36364, which fixes #35702.

Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with nits mentioned above, but since I'm a partial author you should get another set of eyes to look over it, too~

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little leery of the complexity of this change right at the end of the beta.
But @weswigham argues that we remove some scary complexity from contextual typing and push it right to the edge the checker's API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants