Skip to content

Fix wrong script info used to resolve line/offset for call hierarchy #36559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

rbuckton
Copy link
Member

@rbuckton rbuckton commented Jan 31, 2020

This fixes two issues with call hierarchy:

  • When preparing a call hierarchy item we were incorrectly using the script info for the file at the current cursor position when resolving line/character for item's declaration, which could be in another file.
  • When resolving incoming calls, we were incorrectly using the script info for the current call hierarchy item rather than the script info for the file containing the incoming declaration.

Note that the current behavior for outgoing calls is correct (it uses the script info for the current call hierarchy item).

Fixes #36509
Fixes #36512

@rbuckton rbuckton merged commit 9a357c1 into master Jan 31, 2020
@rbuckton rbuckton deleted the fix36509 branch January 31, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants