Skip to content

fix(36883): accessor allows this parameter but is not checked or enforced #36889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2020
Merged

fix(36883): accessor allows this parameter but is not checked or enforced #36889

merged 2 commits into from
Mar 3, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #36883

@a-tarasyuk a-tarasyuk force-pushed the bug/36883 branch 4 times, most recently from 984f060 to 6376ce6 Compare February 20, 2020 10:43
@DanielRosenwasser
Copy link
Member

@typescript-bot test this
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 20, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at ae8f5c7. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 20, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at ae8f5c7. You can monitor the build here. It should now contribute to this PR's status checks.

@DanielRosenwasser
Copy link
Member

@typescript-bot test this
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 25, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at ae8f5c7. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 25, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at ae8f5c7. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request Feb 25, 2020
Closed
@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@DanielRosenwasser DanielRosenwasser merged commit 3046a54 into microsoft:master Mar 3, 2020
This was referenced Mar 5, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees
No one assigned
Labels
None yet
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

accessor allows this parameter but is not checked or enforced.
3 participants
@a-tarasyuk @DanielRosenwasser @typescript-bot