Skip to content

When the global file is deleted mark all files as changed #37538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2020

Conversation

sheetalkamat
Copy link
Member

Fixes #36728

It would be easier to look at the change commit wise since lot of baselines have changed because of added affectsGlobalScope file info property
4da9fc5 adds test that shows the current behavior of the issue
f34d481 fix and updates the above test to show its fixed
e282da1 fixes all the rest baselines

@sheetalkamat
Copy link
Member Author

sheetalkamat commented Mar 25, 2020

ping @andrewbranch @sandersn

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the commit-wise breakdown; makes sense to me.

@sheetalkamat sheetalkamat merged commit fd9e602 into master Mar 25, 2020
@sheetalkamat sheetalkamat deleted the globalDelete branch March 25, 2020 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental builds ignore missing ambient declarations
4 participants