Handle packages inside another node modules package when auto importing #37561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbranch
approved these changes
Mar 25, 2020
| if (!moduleFileNameForExtensionless) moduleFileNameForExtensionless = moduleFileToTry; | ||
|
|
||
| // try with next level of directory | ||
| packageRootIndex = moduleFileName.indexOf(directorySeparator, packageRootIndex + 1); |
There was a problem hiding this comment.
Just to make sure I’m understanding this correctly, the idea is:
- we’ve located the
moduleFileName, say,/project/node_modules/preact/hooks/src/index.js - we look at the structure of the path (as before) to call
/project/node_modules/preactthe “package root” - we see if
moduleFileNameis accessible (via a package.json main field) from/project/node_modules/preact - if not, go to step 3 but with one more directory appended to the end (in the first iteration of this case,
/project/node_modules/preact/hooks)
As contrasted to the previous behavior, where we’d only try the package root before giving up and using the full moduleFileName (optionally with /index.js taken off the end).
|
Thank you so much for fixing this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37542