Skip to content

Preserve module marker in es2015+ module emit for tool compatibility #38712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2020
Merged

Preserve module marker in es2015+ module emit for tool compatibility #38712

merged 1 commit into from
May 21, 2020

Conversation

weswigham
Copy link
Member

Fixes #38696

@weswigham weswigham force-pushed the preserve-module-marker branch from 9593a90 to 1378ebb Compare May 21, 2020 18:46
@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 21, 2020 •
edited
Loading

@typescript-bot pack this

CC @JasonGore @kenotron

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 21, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 1378ebb. You can monitor the build here.

@DanielRosenwasser DanielRosenwasser mentioned this pull request May 21, 2020
Closed
@typescript-bot
Copy link
Collaborator

typescript-bot commented May 21, 2020 •
edited
Loading

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/74637/artifacts?artifactName=tgz&fileId=42746E9DAEFBC3099CB30BC33DA3823DF5EA3ED9F2D869F5535525282926118D02&fileName=/typescript-4.0.0-insiders.20200521.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

@weswigham weswigham merged commit 0018b8f into microsoft:master May 21, 2020
@weswigham
Copy link
Member Author

@typescript-bot cherry-pick this into release-3.9

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 21, 2020 •
edited
Loading

Heya @weswigham, I've started to run the task to cherry-pick this into release-3.9 on this PR at 1378ebb. You can monitor the build here.

@typescript-bot typescript-bot mentioned this pull request May 21, 2020
Closed
@typescript-bot
Copy link
Collaborator

Hey @weswigham, I've opened #38717 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request May 21, 2020
@weswigham @typescript-bot
Cherry-pick PR microsoft#38712 into release-3.9
7c77bbb 
Component commits:
1378ebb Preserve module marker in es2015+ module emit for tool compatability
cangSDARM added a commit to cangSDARM/TypeScript that referenced this pull request May 26, 2020
@cangSDARM
Merge remote-tracking branch 'upstream/master'
470bcf6 
* upstream/master:
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Fix relation between generic mapped types and types with index signatures (microsoft#38761)
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Revert "Wrap classes with decorators or static properties in an IIFE, even for ES2015+ (microsoft#32011)"
  Preserve module marker in es2015+ module emit for tool compatability (microsoft#38712)
  Fix recently added test so it is cross-plat
  fix(33286): add outlining for arrow function with one parameter (microsoft#38631)
  fix(38463): show completions for index access properties
@IllusionMH IllusionMH mentioned this pull request Jul 14, 2020
Closed
@WORMSS
Copy link

WORMSS commented Jul 14, 2020

How do I get Typescript to NOT keep the empty export code?
It breaks the ability to compile code with no exports and have it run in the browser.

@andrewbranch andrewbranch mentioned this pull request Nov 17, 2020
Open
5 tasks
@DanielRosenwasser DanielRosenwasser mentioned this pull request Feb 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

@sheetalkamat sheetalkamat sheetalkamat approved these changes

@rbuckton rbuckton Awaiting requested review from rbuckton

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@weswigham weswigham

Labels
Author: Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider emitting export {} in all ambiguous module output
5 participants
@weswigham @DanielRosenwasser @typescript-bot @WORMSS @sheetalkamat