Skip to content

Flag mapped types with circular property types and do not attempt to print them structurally #39552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2020
Merged

Flag mapped types with circular property types and do not attempt to print them structurally #39552

merged 1 commit into from
Jul 15, 2020

Conversation

weswigham
Copy link
Member

Fixes #39495

@weswigham weswigham requested review from sandersn and ahejlsberg July 10, 2020 17:49
sandersn
sandersn approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as the new property doesn't slow down MappedType.

@weswigham weswigham merged commit f2c5643 into microsoft:master Jul 15, 2020
@weswigham weswigham deleted the instantiation-stackoverflow branch July 15, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@ahejlsberg ahejlsberg Awaiting requested review from ahejlsberg

Assignees

@weswigham weswigham

Labels
Author: Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack overflow upon instantiating unbounded recursive type
3 participants
@weswigham @sandersn @typescript-bot