-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Fixes confusing logs and unnecessary configFile checks from navto by keeping project with result. #39721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also cache the result of config file name for open files Fixes #38491
@amcasey @mjbvz @sandersn its not clear if we need to change behaviour to only currently open projects instead of looking in all projects like findAllRefs is suppose to do for navTo, @sandersn added this as part of #38027 and i am not sure if this need to change and if yes how Btw to me #38027 seems the right behaviour. People want to search in their workspace as opposed to open projects i think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This definitely seems like it would improve performance (did we measure?) but I agree that further discussion is needed around what we actually want FAR to do in these scenarios. I agree that the behavior in #38027 matches my expectations for how the feature should work, but I believe it was originally motivated by a request from @mjbvz and I had the impression that it might not have matched his expectations.
@amcasey I think the title was log. I only picked up title from the issue but as issue explains the slowness (if any is expected and controlled by the vscode setting with scope for navTo) but the logs were confusing and could add little bit delay to get config file name for each nav to result's fileName. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the change is good, but I'm not convinced we should close the linked bug.
Will open new one to discuss the behaviour about opening the issue. |
This fixes multiple issues:
Fixes NavTo seems slower #38491