Skip to content

Handle the fact that noResolveResolution resolution is reused #39889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

sheetalkamat
Copy link
Member

Fixes #39795

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 3, 2020

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.0 on this PR at c3ac7fa. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #39890 for you.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Aug 3, 2020
Component commits:
c3ac7fa Handle the fact that noResolveResolution resolution is reused Fixes microsoft#39795
DanielRosenwasser pushed a commit that referenced this pull request Aug 4, 2020
Component commits:
c3ac7fa Handle the fact that noResolveResolution resolution is reused Fixes #39795

Co-authored-by: Sheetal Nandi <[email protected]>
@sheetalkamat sheetalkamat force-pushed the watchFailedLookupPartialSemantic branch from c3ac7fa to 9d43830 Compare August 4, 2020 18:29
@sheetalkamat sheetalkamat merged commit bcccae2 into master Aug 4, 2020
@sheetalkamat sheetalkamat deleted the watchFailedLookupPartialSemantic branch August 4, 2020 20:33
@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.0 and LKG

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 4, 2020

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.0 on this PR at 9d43830. You can monitor the build here.

@DanielRosenwasser DanielRosenwasser restored the watchFailedLookupPartialSemantic branch August 4, 2020 22:46
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.0 manually.

@DanielRosenwasser DanielRosenwasser deleted the watchFailedLookupPartialSemantic branch August 4, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TS Server fatal error: Debug Failure. False expression.
4 participants