Fix/create element new jsx transform #41151
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| //// [jsxJsxsCjsTransformKeyProp.tsx] | ||
| /// <reference path="/.lib/react16.d.ts" /> | ||
| const props = { answer: 42 } | ||
| const a = <div key="foo" {...props}>text</div>; | ||
| const b = <div {...props} key="bar">text</div>; | ||
|
|
||
| export {}; | ||
|
|
||
|
|
||
| //// [jsxJsxsCjsTransformKeyProp.js] | ||
| "use strict"; | ||
| var __assign = (this && this.__assign) || function () { | ||
| __assign = Object.assign || function(t) { | ||
| for (var s, i = 1, n = arguments.length; i < n; i++) { | ||
| s = arguments[i]; | ||
| for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p)) | ||
| t[p] = s[p]; | ||
| } | ||
| return t; | ||
| }; | ||
| return __assign.apply(this, arguments); | ||
| }; | ||
| exports.__esModule = true; | ||
| var react_1 = require("react"); | ||
| var jsx_runtime_1 = require("react/jsx-runtime"); | ||
| /// <reference path="react16.d.ts" /> | ||
| var props = { answer: 42 }; | ||
| var a = jsx_runtime_1.jsx("div", __assign({}, props, { children: "text" }), "foo"); | ||
| var b = react_1.createElement("div", __assign({}, props, { key: "bar" }), "text"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| === tests/cases/conformance/jsx/jsxs/jsxJsxsCjsTransformKeyProp.tsx === | ||
| /// <reference path="react16.d.ts" /> | ||
| const props = { answer: 42 } | ||
| >props : Symbol(props, Decl(jsxJsxsCjsTransformKeyProp.tsx, 1, 5)) | ||
| >answer : Symbol(answer, Decl(jsxJsxsCjsTransformKeyProp.tsx, 1, 15)) | ||
|
|
||
| const a = <div key="foo" {...props}>text</div>; | ||
| >a : Symbol(a, Decl(jsxJsxsCjsTransformKeyProp.tsx, 2, 5)) | ||
| >div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114)) | ||
| >key : Symbol(key, Decl(jsxJsxsCjsTransformKeyProp.tsx, 2, 14)) | ||
| >props : Symbol(props, Decl(jsxJsxsCjsTransformKeyProp.tsx, 1, 5)) | ||
| >div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114)) | ||
|
|
||
| const b = <div {...props} key="bar">text</div>; | ||
| >b : Symbol(b, Decl(jsxJsxsCjsTransformKeyProp.tsx, 3, 5)) | ||
| >div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114)) | ||
| >props : Symbol(props, Decl(jsxJsxsCjsTransformKeyProp.tsx, 1, 5)) | ||
| >key : Symbol(key, Decl(jsxJsxsCjsTransformKeyProp.tsx, 3, 25)) | ||
| >div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114)) | ||
|
|
||
| export {}; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| === tests/cases/conformance/jsx/jsxs/jsxJsxsCjsTransformKeyProp.tsx === | ||
| /// <reference path="react16.d.ts" /> | ||
| const props = { answer: 42 } | ||
| >props : { answer: number; } | ||
| >{ answer: 42 } : { answer: number; } | ||
| >answer : number | ||
| >42 : 42 | ||
|
|
||
| const a = <div key="foo" {...props}>text</div>; | ||
| >a : JSX.Element | ||
| ><div key="foo" {...props}>text</div> : JSX.Element | ||
| >div : any | ||
| >key : string | ||
| >props : { answer: number; } | ||
| >div : any | ||
|
|
||
| const b = <div {...props} key="bar">text</div>; | ||
| >b : JSX.Element | ||
| ><div {...props} key="bar">text</div> : JSX.Element | ||
| >div : any | ||
| >props : { answer: number; } | ||
| >key : string | ||
| >div : any | ||
|
|
||
| export {}; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| //// [jsxJsxsCjsTransformKeyProp.tsx] | ||
| /// <reference path="/.lib/react16.d.ts" /> | ||
| const props = { answer: 42 } | ||
| const a = <div key="foo" {...props}>text</div>; | ||
| const b = <div {...props} key="bar">text</div>; | ||
|
|
||
| export {}; | ||
|
|
||
|
|
||
| //// [jsxJsxsCjsTransformKeyProp.js] | ||
| "use strict"; | ||
| var __assign = (this && this.__assign) || function () { | ||
| __assign = Object.assign || function(t) { | ||
| for (var s, i = 1, n = arguments.length; i < n; i++) { | ||
| s = arguments[i]; | ||
| for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p)) | ||
| t[p] = s[p]; | ||
| } | ||
| return t; | ||
| }; | ||
| return __assign.apply(this, arguments); | ||
| }; | ||
| exports.__esModule = true; | ||
| var react_1 = require("react"); | ||
| var jsx_dev_runtime_1 = require("react/jsx-dev-runtime"); | ||
| var _jsxFileName = "tests/cases/conformance/jsx/jsxs/jsxJsxsCjsTransformKeyProp.tsx"; | ||
| /// <reference path="react16.d.ts" /> | ||
| var props = { answer: 42 }; | ||
| var a = jsx_dev_runtime_1.jsxDEV("div", __assign({}, props, { children: "text" }), "foo", false, { fileName: _jsxFileName, lineNumber: 3, columnNumber: 10 }, this); | ||
| var b = react_1.createElement("div", __assign({}, props, { key: "bar" }), "text"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| === tests/cases/conformance/jsx/jsxs/jsxJsxsCjsTransformKeyProp.tsx === | ||
| /// <reference path="react16.d.ts" /> | ||
| const props = { answer: 42 } | ||
| >props : Symbol(props, Decl(jsxJsxsCjsTransformKeyProp.tsx, 1, 5)) | ||
| >answer : Symbol(answer, Decl(jsxJsxsCjsTransformKeyProp.tsx, 1, 15)) | ||
|
|
||
| const a = <div key="foo" {...props}>text</div>; | ||
| >a : Symbol(a, Decl(jsxJsxsCjsTransformKeyProp.tsx, 2, 5)) | ||
| >div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114)) | ||
| >key : Symbol(key, Decl(jsxJsxsCjsTransformKeyProp.tsx, 2, 14)) | ||
| >props : Symbol(props, Decl(jsxJsxsCjsTransformKeyProp.tsx, 1, 5)) | ||
| >div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114)) | ||
|
|
||
| const b = <div {...props} key="bar">text</div>; | ||
| >b : Symbol(b, Decl(jsxJsxsCjsTransformKeyProp.tsx, 3, 5)) | ||
| >div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114)) | ||
| >props : Symbol(props, Decl(jsxJsxsCjsTransformKeyProp.tsx, 1, 5)) | ||
| >key : Symbol(key, Decl(jsxJsxsCjsTransformKeyProp.tsx, 3, 25)) | ||
| >div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114)) | ||
|
|
||
| export {}; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| === tests/cases/conformance/jsx/jsxs/jsxJsxsCjsTransformKeyProp.tsx === | ||
| /// <reference path="react16.d.ts" /> | ||
| const props = { answer: 42 } | ||
| >props : { answer: number; } | ||
| >{ answer: 42 } : { answer: number; } | ||
| >answer : number | ||
| >42 : 42 | ||
|
|
||
| const a = <div key="foo" {...props}>text</div>; | ||
| >a : JSX.Element | ||
| ><div key="foo" {...props}>text</div> : JSX.Element | ||
| >div : any | ||
| >key : string | ||
| >props : { answer: number; } | ||
| >div : any | ||
|
|
||
| const b = <div {...props} key="bar">text</div>; | ||
| >b : JSX.Element | ||
| ><div {...props} key="bar">text</div> : JSX.Element | ||
| >div : any | ||
| >props : { answer: number; } | ||
| >key : string | ||
| >div : any | ||
|
|
||
| export {}; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| //// [jsxJsxsCjsTransformKeyPropCustomImport.tsx] | ||
| /// <reference path="/.lib/react16.d.ts" /> | ||
| const props = { answer: 42 } | ||
| const a = <div key="foo" {...props}>text</div>; | ||
| const b = <div {...props} key="bar">text</div>; | ||
|
|
||
| export {}; | ||
|
|
||
|
|
||
| //// [jsxJsxsCjsTransformKeyPropCustomImport.js] | ||
| "use strict"; | ||
| var __assign = (this && this.__assign) || function () { | ||
| __assign = Object.assign || function(t) { | ||
| for (var s, i = 1, n = arguments.length; i < n; i++) { | ||
| s = arguments[i]; | ||
| for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p)) | ||
| t[p] = s[p]; | ||
| } | ||
| return t; | ||
| }; | ||
| return __assign.apply(this, arguments); | ||
| }; | ||
| exports.__esModule = true; | ||
| var preact_1 = require("preact"); | ||
| var jsx_runtime_1 = require("preact/jsx-runtime"); | ||
| /// <reference path="react16.d.ts" /> | ||
| var props = { answer: 42 }; | ||
| var a = jsx_runtime_1.jsx("div", __assign({}, props, { children: "text" }), "foo"); | ||
| var b = preact_1.createElement("div", __assign({}, props, { key: "bar" }), "text"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| === tests/cases/conformance/jsx/jsxs/jsxJsxsCjsTransformKeyPropCustomImport.tsx === | ||
| /// <reference path="react16.d.ts" /> | ||
| const props = { answer: 42 } | ||
| >props : Symbol(props, Decl(jsxJsxsCjsTransformKeyPropCustomImport.tsx, 1, 5)) | ||
| >answer : Symbol(answer, Decl(jsxJsxsCjsTransformKeyPropCustomImport.tsx, 1, 15)) | ||
|
|
||
| const a = <div key="foo" {...props}>text</div>; | ||
| >a : Symbol(a, Decl(jsxJsxsCjsTransformKeyPropCustomImport.tsx, 2, 5)) | ||
| >div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114)) | ||
| >key : Symbol(key, Decl(jsxJsxsCjsTransformKeyPropCustomImport.tsx, 2, 14)) | ||
| >props : Symbol(props, Decl(jsxJsxsCjsTransformKeyPropCustomImport.tsx, 1, 5)) | ||
| >div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114)) | ||
|
|
||
| const b = <div {...props} key="bar">text</div>; | ||
| >b : Symbol(b, Decl(jsxJsxsCjsTransformKeyPropCustomImport.tsx, 3, 5)) | ||
| >div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114)) | ||
| >props : Symbol(props, Decl(jsxJsxsCjsTransformKeyPropCustomImport.tsx, 1, 5)) | ||
| >key : Symbol(key, Decl(jsxJsxsCjsTransformKeyPropCustomImport.tsx, 3, 25)) | ||
| >div : Symbol(JSX.IntrinsicElements.div, Decl(react16.d.ts, 2420, 114)) | ||
|
|
||
| export {}; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| === tests/cases/conformance/jsx/jsxs/jsxJsxsCjsTransformKeyPropCustomImport.tsx === | ||
| /// <reference path="react16.d.ts" /> | ||
| const props = { answer: 42 } | ||
| >props : { answer: number; } | ||
| >{ answer: 42 } : { answer: number; } | ||
| >answer : number | ||
| >42 : 42 | ||
|
|
||
| const a = <div key="foo" {...props}>text</div>; | ||
| >a : JSX.Element | ||
| ><div key="foo" {...props}>text</div> : JSX.Element | ||
| >div : any | ||
| >key : string | ||
| >props : { answer: number; } | ||
| >div : any | ||
|
|
||
| const b = <div {...props} key="bar">text</div>; | ||
| >b : JSX.Element | ||
| ><div {...props} key="bar">text</div> : JSX.Element | ||
| >div : any | ||
| >props : { answer: number; } | ||
| >key : string | ||
| >div : any | ||
|
|
||
| export {}; | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the signature differs now from the accompanying
createExpressionForJsxFragmentbut this is just a util file so I don't think it's particularly important but let me know if you'd like this to be refactored somehow.